GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix typo in src code guide by tniessen · Pull Request #37956 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Mar 28, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
src: fix typo in src code guide
451eb3b
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 28, 2021
addaleax
addaleax approved these changes Mar 28, 2021
View reviewed changes
@addaleax

addaleax commented Mar 28, 2021

Copy link
Copy Markdown
Member

👍 to fast-track, by the way (if we're still doing that)
targos and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed needs-ci PRs that need a full CI run. labels Mar 28, 2021
targos
targos approved these changes Mar 28, 2021
View reviewed changes
Vonaras4
Vonaras4 approved these changes Mar 28, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Mar 28, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Mar 28, 2021
View reviewed changes
RaisinTen pushed a commit that referenced this pull request Mar 28, 2021
@tniessen @RaisinTen
src: fix typo in src code guide
ed6e8f6 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@RaisinTen

RaisinTen commented Mar 28, 2021

Copy link
Copy Markdown
Member

Landed in ed6e8f6
richardlau reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen closed this Mar 28, 2021
richardlau
richardlau approved these changes Mar 28, 2021
View reviewed changes
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@tniessen @ruyadorno
src: fix typo in src code guide
3e96f43 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@tniessen @ruyadorno
src: fix typo in src code guide
bd87e19 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
v15.13.0 proposal #37977
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@tniessen @targos
src: fix typo in src code guide
d0cb129 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@tniessen
tniessen deleted the src-readme-typo branch October 7, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@Vonaras4 Vonaras4 Vonaras4 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@tniessen @addaleax @RaisinTen @targos @richardlau @Lxxyx @Vonaras4 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.