GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix typo for initialization by yashLadha · Pull Request #37974 · nodejs/node

Conversation

@yashLadha

@yashLadha yashLadha commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yashLadha
src: fix typo for initialization
4cd7375
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 30, 2021
cjihrig
cjihrig approved these changes Mar 30, 2021
View reviewed changes
marsonya
marsonya approved these changes Mar 30, 2021
View reviewed changes
addaleax
addaleax approved these changes Mar 30, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Mar 30, 2021
View reviewed changes
Trott
Trott approved these changes Apr 2, 2021
View reviewed changes
PoojaDurgad
PoojaDurgad approved these changes Apr 5, 2021
View reviewed changes
@PoojaDurgad PoojaDurgad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 5, 2021
jasnell
jasnell approved these changes Apr 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Apr 7, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37255/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha

yashLadha commented Apr 8, 2021

Copy link
Copy Markdown
Contributor Author

Should I go ahead and deploy, it doesn't seem that big of a change @jasnell 😅 and is open for quite some time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Apr 8, 2021

Copy link
Copy Markdown
Member

We have to get a good ci run first. It's irritating that ci has been so flaky but it's gotta be yellow or green before this can land
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37294/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen pushed a commit that referenced this pull request Apr 8, 2021
@yashLadha @RaisinTen
src: fix typo for initialization
8d63aa8 
PR-URL: #37974
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RaisinTen

RaisinTen commented Apr 8, 2021

Copy link
Copy Markdown
Member

Landed in 8d63aa8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen closed this Apr 8, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@yashLadha @targos
src: fix typo for initialization
854a2a9 
PR-URL: #37974
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@yashLadha @nodejs-github-bot @jasnell @RaisinTen @Trott @addaleax @cjihrig @marsonya @PoojaDurgad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.