GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — worker: fix exit code for error thrown in uncaughtException handler by Linkgoron · Pull Request #38012 · nodejs/node Conversation
|
|
Thanks for fixing this so quickly. I think the docs need an update as well if we're going with 7 and not 1
https://nodejs.org/api/worker_threads.html#worker_threads_event_exit |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've changed the exit code to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
287f22e to
7779d71
Compare
|
@nodejs/workers |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/37206/ 💚 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Change worker exit code when the unhandled exception handler throws from 0 to 7 fixes: #37996 PR-URL: #38012 Fixes: #37996 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 6986fa0 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
thanks!
The 7 slipped in there again "from 0 to 7" |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Yeah, it looks like I missed amending the commit message. The PR is good though, and correctly exits with |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Change worker exit code when the unhandled exception handler throws from 0 to 7 fixes: #37996 PR-URL: #38012 Fixes: #37996 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Worker exits with code 0 (and not 7) when throwing inside uncaughtException
There was an error while loading. Please reload this page.