GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: package release changelog for releases by richardlau · Pull Request #38033 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Apr 2, 2021

Copy link
Copy Markdown
Member

Package the changelog for the release line as CHANGELOG.md when
building a release binary tarball.

Fixes: #38025

cc @nodejs/releasers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and danielleadams reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@richardlau
build: package release changelog for releases
96e4115 
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Apr 2, 2021
@richardlau richardlau mentioned this pull request Apr 2, 2021
distributed CHANGELOG is useless #38025
Closed
juanarbol
juanarbol approved these changes Apr 3, 2021
View reviewed changes
Trott
Trott approved these changes Apr 3, 2021
View reviewed changes
targos
targos approved these changes Apr 4, 2021
View reviewed changes
BethGriggs
BethGriggs approved these changes Apr 6, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell
jasnell approved these changes Apr 6, 2021
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 6, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37261/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Apr 7, 2021

Copy link
Copy Markdown
Member

Landed in 9cfb418
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 7, 2021
jasnell pushed a commit that referenced this pull request Apr 7, 2021
@richardlau @jasnell
build: package release changelog for releases
9cfb418 
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: #38033
Fixes: #38025
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@richardlau @targos
build: package release changelog for releases
079d90b 
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: #38033
Fixes: #38025
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

distributed CHANGELOG is useless

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@richardlau @nodejs-github-bot @jasnell @Trott @targos @BethGriggs @juanarbol @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.