GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky timeout-request body and headers tests by Linkgoron · Pull Request #38045 · nodejs/node

Conversation

@Linkgoron

@Linkgoron Linkgoron commented Apr 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fix the flaky test-http-server-request-timeout-delayed-body and test-http-server-request-timeout-delayed-headers tests which sometimes fail on slow systems. This happened to me today on the raspberry pi CI, and I could reproduce this locally by running /tools/test.py -j250 --repeat=1000 test/parallel/test-http-server-request-timeout-delayed-body.js. I could not reproduce the issue after my fix.

The reason, I believe, is that sometimes it takes more than a second for the request to "reach" the server. I've changed the tests to delay the body/headers sending to only happen when we're sure that a connection was made with the server.

EDIT:
Also added the same fix to:

  • test/parallel/test-http-server-request-timeout-interrupted-body.js
  • test/parallel/test-http-server-request-timeout-interrupted-headers.js
  • test/parallel/test-http-server-request-timeout-upgrade.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 2, 2021
benjamingr
benjamingr approved these changes Apr 2, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37111/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37113/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37114/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37116/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Apr 3, 2021

Copy link
Copy Markdown
Member

@nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Linkgoron Linkgoron added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Apr 3, 2021
@Linkgoron Linkgoron changed the title test: fix flaky timeout-delayed-body and headers tests test: fix flaky timeout-request body and headers tests Apr 3, 2021
@Linkgoron

Linkgoron commented Apr 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Added the same fix to 3 other tests that check requestTimeout. There's also an open issue for flakiness in test-http-request-timeout-keepalive (which I didn't change), but I think that the flakiness there is caused by a different problem.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Linkgoron
Linkgoron force-pushed the test-delayed-timeout-flaky-tests branch from adf4624 to 3b82eee Compare April 3, 2021 16:50
benjamingr
benjamingr approved these changes Apr 3, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37130/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Linkgoron Linkgoron added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 5, 2021
Trott
Trott approved these changes Apr 5, 2021
View reviewed changes
@Linkgoron @Trott
test: fix flaky timeout-delayed-body and headers tests
d75543d 
fix the flaky test-http-server-request-timeout-delayed-body
and test-http-server-request-timeout-delayed-headers which
sometimes fail on slow systems.

PR-URL: nodejs#38045
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Trott force-pushed the test-delayed-timeout-flaky-tests branch from 3b82eee to d75543d Compare April 5, 2021 14:49
@Trott

Trott commented Apr 5, 2021

Copy link
Copy Markdown
Member

Landed in d75543d
Linkgoron reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Apr 5, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Linkgoron @targos
test: fix flaky timeout-delayed-body and headers tests
1cb3d89 
fix the flaky test-http-server-request-timeout-delayed-body
and test-http-server-request-timeout-delayed-headers which
sometimes fail on slow systems.

PR-URL: #38045
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Linkgoron @nodejs-github-bot @targos @Trott @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.