GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add link to V8 by VoltrexKeyva · Pull Request #38144 · nodejs/node

Conversation

@VoltrexKeyva

@VoltrexKeyva VoltrexKeyva commented Apr 8, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Added the link redirecting to the V8 engine main domain just like libuv.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@VoltrexKeyva
doc: add link to V8
3bd64e2 
Added the link redirecting to the V8 engine github repository just like libuv.
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to Node.js documentation. labels Apr 8, 2021
@VoltrexKeyva
Fix link order
df36942 
V8 should be above Worker.
gengjiawen
gengjiawen approved these changes Apr 8, 2021
View reviewed changes
jasnell
jasnell approved these changes Apr 8, 2021
View reviewed changes
RaisinTen
RaisinTen approved these changes Apr 8, 2021
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2021
richardlau
richardlau reviewed Apr 8, 2021
View reviewed changes
Comment thread doc/api/addons.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@VoltrexKeyva
Refer to the main V8 domain
0c108a0 
V8 redirect URL should redirect to the google source original domain instead of the mirror.
richardlau
richardlau approved these changes Apr 8, 2021
View reviewed changes
addaleax
addaleax approved these changes Apr 8, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Apr 9, 2021
View reviewed changes
marsonya
marsonya approved these changes Apr 9, 2021
View reviewed changes
RaisinTen pushed a commit that referenced this pull request Apr 10, 2021
@VoltrexKeyva @RaisinTen
doc: add link to V8
6a2314a 
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RaisinTen

RaisinTen commented Apr 10, 2021

Copy link
Copy Markdown
Member

Landed in 6a2314a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen closed this Apr 10, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
@VoltrexKeyva
VoltrexKeyva deleted the patch-2 branch April 17, 2021 03:08
targos pushed a commit that referenced this pull request May 1, 2021
@VoltrexKeyva @targos
doc: add link to V8
424c8e1 
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@VoltrexKeyva @danielleadams
doc: add link to V8
52be691 
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@VoltrexKeyva @RaisinTen @jasnell @addaleax @cjihrig @gengjiawen @richardlau @marsonya @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.