GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-zlib-unused-weak.js by oyyd · Pull Request #38149 · nodejs/node

Conversation

@oyyd

@oyyd oyyd commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

Failed test: https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-last-latest-x64/40825/testReport/junit/(root)/test/parallel_test_zlib_unused_weak/

AssertionError [ERR_ASSERTION]: Expected after-GC delta -29156 to be less than 5 % of before-GC delta -9751

I think the delta should be positive. Calling gc() before zlib.createGzip() should make it more stable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oyyd
test: fix flaky test-zlib-unused-weak.js
261f330
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 8, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37292/
massto reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau mentioned this pull request Apr 8, 2021
ansible: add Debian 10 nodejs/build#2612
Merged
richardlau
richardlau approved these changes Apr 8, 2021
View reviewed changes
jasnell
jasnell approved these changes Apr 8, 2021
View reviewed changes
addaleax
addaleax approved these changes Apr 8, 2021
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2021
@lpinca lpinca mentioned this pull request Apr 9, 2021
http: fixup perf regression #38110
Closed
lpinca
lpinca approved these changes Apr 9, 2021
View reviewed changes
@lpinca

lpinca commented Apr 9, 2021

Copy link
Copy Markdown
Member

Fast-track?
lpinca and mcollina reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented Apr 9, 2021

Copy link
Copy Markdown
Member

+1 to fast track
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Apr 9, 2021
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@oyyd oyyd added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 9, 2021
oyyd added a commit that referenced this pull request Apr 9, 2021
@oyyd
test: fix flaky test-zlib-unused-weak.js
f96dffb 
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@oyyd

oyyd commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

Landed in f96dffb, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oyyd oyyd closed this Apr 9, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@oyyd @targos
test: fix flaky test-zlib-unused-weak.js
e999da7 
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@oyyd @danielleadams
test: fix flaky test-zlib-unused-weak.js
865046c 
PR-URL: #38149
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@oyyd @nodejs-github-bot @lpinca @mcollina @jasnell @addaleax @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.