GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: add command flag to import.meta.resolve by iguessitsokay · Pull Request #38171 · nodejs/node

Conversation

@iguessitsokay

@iguessitsokay iguessitsokay commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

import.meta.resolve is only available under --experimental-import-meta-resolve cli flag.

Source:

node/lib/internal/modules/esm/translators.js

Line 132 in e46c680

if (experimentalImportMetaResolve)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iguessitsokay
docs: add command flag to import.meta.resolve
39bc31b 
import.meta.resolve is only available under --experimental-import-meta-resolve cli flag.

Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 9, 2021
marsonya
marsonya requested changes Apr 9, 2021
View reviewed changes

@marsonya marsonya left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iguessitsokay @marsonya
fix lint error
2b0ccd6 
thanks @marsonya

Co-authored-by: akhil marsonya <[email protected]>
RaisinTen
RaisinTen reviewed Apr 10, 2021
View reviewed changes
Comment thread doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iguessitsokay @RaisinTen
remove italic style
447e1cb 
thanks @RaisinTen

Co-authored-by: Darshan Sen <[email protected]>
@iguessitsokay iguessitsokay mentioned this pull request Apr 11, 2021
docs: standardize command flag notes #38199
Closed
RaisinTen
RaisinTen approved these changes Apr 11, 2021
View reviewed changes
@RaisinTen

RaisinTen commented Apr 11, 2021

Copy link
Copy Markdown
Member

nit: docs -> doc in the commit message (could be fixed while landing)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Apr 11, 2021
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 11, 2021
marsonya
marsonya approved these changes Apr 11, 2021
View reviewed changes
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@iguessitsokay @jasnell
doc: add command flag to import.meta.resolve
eee2c33 
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.

Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132

PR-URL: #38171
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

Landed in eee2c33
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 12, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@iguessitsokay @BethGriggs
doc: add command flag to import.meta.resolve
b61ff83 
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.

Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132

PR-URL: #38171
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@iguessitsokay @targos
doc: add command flag to import.meta.resolve
be28376 
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.

Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132

PR-URL: #38171
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@iguessitsokay @danielleadams
doc: add command flag to import.meta.resolve
3545b5e 
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.

Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132

PR-URL: #38171
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iguessitsokay @RaisinTen @jasnell @marsonya @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.