GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib/path: Add JSDoc Types by Skn0tt · Pull Request #38186 · nodejs/node

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

Inspired by @bmeck: https://twitter.com/bradleymeck/status/1380643627211354115

Changes based on https://nodejs.org/dist/latest-v14.x/docs/api/path.html#path_path_delimiter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Apr 10, 2021
@Skn0tt

Skn0tt commented Apr 10, 2021

Copy link
Copy Markdown
Contributor Author

I hope this PR and #38185 are of help. Let me know if I need to change anything :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ayase-252
Ayase-252 reviewed Apr 10, 2021
View reviewed changes

@Ayase-252 Ayase-252 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Ayase-252
Ayase-252 reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Ayase-252

Ayase-252 commented Apr 10, 2021

Copy link
Copy Markdown
Member

Hi, @Skn0tt

It seems there are still some errors from linters, would you mind fix them?

/home/runner/work/node/node/lib/path.js
Error:   1276:26  error  Trailing spaces not allowed                          no-trailing-spaces
Error:   1306:26  error  Trailing spaces not allowed                          no-trailing-spaces
Error:   1307:25  error  Trailing spaces not allowed                          no-trailing-spaces
Error:   1386:26  error  Trailing spaces not allowed                          no-trailing-spaces
Error:   1444:26  error  Trailing spaces not allowed                          no-trailing-spaces
Error:   1445:1   error  This line has a length of 86. Maximum allowed is 80  max-len

You can also run linters locally to detect linting problem by make lint or vcbuild lint based on your platform. Please refer to Running Tests section.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the typings Issues and PRs related to internal TypeScript declarations. label Apr 11, 2021
bmeck
bmeck approved these changes Apr 12, 2021
View reviewed changes

@bmeck bmeck left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
targos
targos reviewed Apr 13, 2021
View reviewed changes
Comment thread lib/path.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos targos self-assigned this Apr 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37459/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Apr 14, 2021
View reviewed changes
@Skn0tt @targos
typings: add JSDoc types to lib/path
7adcd94
@targos
targos force-pushed the path-jsdoc-types branch from 161c036 to 7adcd94 Compare April 14, 2021 15:06
targos pushed a commit that referenced this pull request Apr 14, 2021
@Skn0tt @targos
typings: add JSDoc types to lib/path
f1a21e5 
PR-URL: #38186
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos

targos commented Apr 14, 2021

Copy link
Copy Markdown
Member

Landed in f1a21e5. Thanks for the contribution!
Skn0tt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Apr 14, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Skn0tt @BethGriggs
typings: add JSDoc types to lib/path
ba20adf 
PR-URL: #38186
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Skn0tt @targos
typings: add JSDoc types to lib/path
e2c2f2b 
PR-URL: #38186
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Skn0tt @danielleadams
typings: add JSDoc types to lib/path
487fc31 
PR-URL: #38186
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayase-252 Ayase-252 Ayase-252 left review comments
+3 more reviewers
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
@bmeck bmeck bmeck approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Skn0tt @Ayase-252 @nodejs-github-bot @targos @bmeck @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.