GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: add JSDoc typings for http by VoltrexKeyva · Pull Request #38191 · nodejs/node

Conversation

@VoltrexKeyva

@VoltrexKeyva VoltrexKeyva commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

Added JSDoc typings for the http lib.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@VoltrexKeyva
lib: add JSDoc typings for http
2d0d5f2 
Added JSDoc typings for the http lib.
@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Apr 10, 2021
@targos targos added the typings Issues and PRs related to internal TypeScript declarations. label Apr 11, 2021
bmeck
bmeck approved these changes Apr 13, 2021
View reviewed changes

@bmeck bmeck left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely want to do this file iteratively for things like the handlers to not make it too hard to read in PR review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos targos self-assigned this Apr 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37461/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37467/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@VoltrexKeyva VoltrexKeyva changed the title lib: add JSDoc typings for http typings: add JSDoc typings for http Apr 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37493/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Apr 16, 2021
View reviewed changes
targos pushed a commit that referenced this pull request Apr 16, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for http
d3162da 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos

targos commented Apr 16, 2021

Copy link
Copy Markdown
Member

Landed in d3162da
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Apr 16, 2021
@VoltrexKeyva
VoltrexKeyva deleted the patch-4 branch April 16, 2021 05:50
@VoltrexKeyva VoltrexKeyva mentioned this pull request Apr 17, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for http
60c7591 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@VoltrexKeyva @danielleadams
typings: add JSDoc typings for http
5b5597c 
PR-URL: #38191
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@bmeck bmeck bmeck approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@VoltrexKeyva @nodejs-github-bot @targos @bmeck
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.