GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix typo in gtest-all.cc by eltociear · Pull Request #38224 · nodejs/node

Conversation

@eltociear

@eltociear eltociear commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

separater -> separator

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 13, 2021
Trott
Trott approved these changes Apr 13, 2021
View reviewed changes
targos
targos approved these changes Apr 13, 2021
View reviewed changes
@targos

targos commented Apr 13, 2021

Copy link
Copy Markdown
Member

👍 to fast-track
aduh95 reacted with thumbs up emoji eltociear reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 13, 2021
aduh95
aduh95 approved these changes Apr 13, 2021
View reviewed changes
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Apr 13, 2021
@eltociear @aduh95
test: fix typo in gtest-all.cc
9498e97 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95

aduh95 commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Landed in 9498e97
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 9498e97 into nodejs:master Apr 13, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@eltociear @BethGriggs
test: fix typo in gtest-all.cc
313661c 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@eltociear @targos
test: fix typo in gtest-all.cc
95c7dab 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@eltociear @danielleadams
test: fix typo in gtest-all.cc
850dbc5 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@eltociear @targos @aduh95 @Trott @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.