GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — punycode: add pending deprecation by aduh95 · Pull Request #38444 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

Revival of #35092: now that #35091 is in Node.js v16.x, this module is unused in the codebase. I think we should move forward with this deprecation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
punycode: add pending deprecation
f6d0ee6
@aduh95 aduh95 added semver-major PRs that contain breaking changes and should be released in the next major version. punycode Issues and PRs related to the punycode module bundled in Node.js. deprecations Issues and PRs related to deprecations. labels Apr 27, 2021
@github-actions github-actions Bot added the needs-ci PRs that need a full CI run. label Apr 27, 2021
jasnell
jasnell approved these changes Apr 27, 2021
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as this remains as just a --pending-deprecation for a while, +1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 27, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 commented Apr 27, 2021
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
fixup! punycode: add pending deprecation
2299ab1
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax approved these changes Apr 27, 2021
View reviewed changes
@aduh95
fixup! punycode: add pending deprecation
016c214
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37768/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Apr 28, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37773/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Apr 28, 2021
View reviewed changes
trivikr
trivikr approved these changes Apr 30, 2021
View reviewed changes
jasnell pushed a commit that referenced this pull request Apr 30, 2021
@aduh95 @jasnell
punycode: add pending deprecation
40ea8aa 
PR-URL: #38444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jasnell

jasnell commented Apr 30, 2021

Copy link
Copy Markdown
Member

Landed in 40ea8aa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 30, 2021
@targos

targos commented Jul 17, 2021

Copy link
Copy Markdown
Member

Should we really consider new pending deprecations semver-major?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the punycode-pending-deprecation branch July 17, 2021 10:39
@aduh95

aduh95 commented Jul 17, 2021

Copy link
Copy Markdown
Contributor Author

No strong feeling from my side, I added the label to be conservative, but I don't see a problem if this lands in the current release lines.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added notable-change PRs with changes that should be highlighted in changelogs. dont-land-on-v12.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Jul 19, 2021
@targos

targos commented Jul 19, 2021

Copy link
Copy Markdown
Member

I turned it into a notable change. I suggest to land it only on v16.x
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @targos
punycode: add pending deprecation
89b4770 
PR-URL: #38444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs added a commit that referenced this pull request Jul 26, 2021
@BethGriggs
2021-07-27, Version 16.6.0 (Current)
45fe4ab 
Notable changes:

build:
  * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) #39470
deps:
  * (SEMVER-MINOR) restore minimum ICU version to 68 (Michaël Zasso) #39470
  * (SEMVER-MINOR) make V8 9.2 abi-compatible with 9.0 (Michaël Zasso) #39470
  * (SEMVER-MINOR) update V8 to 9.2.230.21 (Michaël Zasso) #39470
inspector:
  * mark as stable (Gireesh Punathil) #37748
perf_hooks:
  * (SEMVER-MINOR) web performance timeline compliance (legendecas) #39297
punycode:
  * add pending deprecation (Antoine du Hamel) #38444
repl:
  * (SEMVER-MINOR) enable --experimental-repl-await /w opt-out (hemanth.hm) #34733

PR-URL: TODO
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
v16.6.0 proposal #39534
Merged
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@aduh95 @BethGriggs
punycode: add pending deprecation
eccc9a6 
PR-URL: #38444
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs added a commit that referenced this pull request Jul 29, 2021
@BethGriggs
2021-07-29, Version 16.6.0 (Current)
21f12e1 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](#39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](#39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](#37748)
- (SEMVER-MINOR) perf_hooks: web performance timeline compliance
  (legendecas) [#39297](#39297)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](#38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](#34733)

PR-URL: #39534
BethGriggs added a commit that referenced this pull request Jul 29, 2021
@BethGriggs
2021-07-29, Version 16.6.0 (Current)
8d2e66c 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](#39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](#39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](#37748)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](#38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](#34733)

PR-URL: #39534
BethGriggs added a commit that referenced this pull request Jul 29, 2021
@BethGriggs
2021-07-29, Version 16.6.0 (Current)
0e22fa0 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](#39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](#39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](#37748)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](#38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](#34733)

PR-URL: #39534
@anonrig anonrig mentioned this pull request Mar 21, 2023
lib: runtime deprecate punycode #47202
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Sep 12, 2026
Prepare Geddes 1.0: XRD readers, x/y API, and package checks jcwang587/geddes#57
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. punycode Issues and PRs related to the punycode module bundled in Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @jasnell @targos @addaleax @lpinca @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.