GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test,readline: improve tab completion coverage by aduh95 · Pull Request #38465 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Blocked on #38464

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Apr 29, 2021
@github-actions github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 29, 2021
@aduh95 aduh95 added readline Issues and PRs related to the built-in readline module. needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. labels Apr 29, 2021
Trott
Trott approved these changes May 2, 2021
View reviewed changes
@aduh95
aduh95 force-pushed the readline-tab-completion-test-coverage branch from b291d15 to 4e2ed40 Compare May 2, 2021 08:39
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot

nodejs-github-bot commented May 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37871/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels May 2, 2021
@aduh95
aduh95 force-pushed the readline-tab-completion-test-coverage branch 2 times, most recently from b291d15 to b53eb32 Compare May 2, 2021 09:58
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed blocked PRs that are blocked by other issues or PRs. labels May 2, 2021
@nodejs-github-bot

nodejs-github-bot commented May 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37874/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes May 2, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37877/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
test,readline: improve tab completion coverage
68e6673 
PR-URL: nodejs#38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@aduh95
aduh95 force-pushed the readline-tab-completion-test-coverage branch from b53eb32 to 68e6673 Compare May 2, 2021 13:05
@aduh95

aduh95 commented May 2, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 68e6673
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 68e6673 into nodejs:master May 2, 2021
@aduh95
aduh95 deleted the readline-tab-completion-test-coverage branch May 2, 2021 13:06
targos pushed a commit that referenced this pull request May 3, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
16eb078 
PR-URL: #38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request May 3, 2021
v16.1.0 release proposal #38522
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
4ce111b 
PR-URL: #38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
af74257 
PR-URL: #38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
dd8dc82 
PR-URL: #38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
test,readline: improve tab completion coverage
bfe02b8 
PR-URL: #38465
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @nodejs-github-bot @Trott @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.