GeezerVison

Copy link

Copy Markdown

Contributor

lin7sh, MomenNano, shrujalshah28, nicolashenry, tsugabloom, and bricss reacted with thumbs up emoji jasnell, bl-ue, lin7sh, MomenNano, and bricss reacted with hooray emoji janbrasna reacted with heart emoji

danbev force-pushed the openssl-3.0-statically-linked branch from bcc569a to 2b5ef85 Compare May 3, 2021 16:30

danbev force-pushed the openssl-3.0-statically-linked branch from 2b5ef85 to eaf8adc Compare May 26, 2021 10:49

danbev force-pushed the openssl-3.0-statically-linked branch from 04ac9e1 to d6fb5d7 Compare May 31, 2021 06:50

danbev force-pushed the openssl-3.0-statically-linked branch from d6fb5d7 to d677da6 Compare May 31, 2021 11:34

danbev force-pushed the openssl-3.0-statically-linked branch from d677da6 to 955920c Compare June 1, 2021 05:57

This commit adds an architecture named aix64-gcc-as which can generate
assembler source code compatible with AIX assembler (as) instead of the
GNU Assembler (gas). This architecture name is then used in a callback
for the .p2align directive which is not available in AIX as.

The motivation for this addition came out of an issue we ran into when
working on upgrading OpenSSL in Node.js. We ran into the following
compilation error on one of the CI machines that uses AIX:

  05:39:05 Assembler:
  05:39:05 crypto/bn/ppc64-mont-fixed.s: line 4: Error In Syntax

This machine is using AIX Version 7.2 and does not have gas installed
and the .p2align directive is causing this error. After asking around if
it would be possible to install GAS on this machine I learned that AIX
GNU utils are not maintained as well as the native AIX ones and we
(Red Hat/IBM) have run into issues with the GNU utils in the past and if
possible it would be preferable to be able to use the AIX native
assembler.

Refs: nodejs/node#38512

This commit adds an architecture named aix64-gcc-as which can generate
assembler source code compatible with AIX assembler (as) instead of the
GNU Assembler (gas). This architecture name is then used in a callback
for the .p2align directive which is not available in AIX as.

The motivation for this addition came out of an issue we ran into when
working on upgrading OpenSSL in Node.js. We ran into the following
compilation error on one of the CI machines that uses AIX:

  05:39:05 Assembler:
  05:39:05 crypto/bn/ppc64-mont-fixed.s: line 4: Error In Syntax

This machine is using AIX Version 7.2 and does not have gas installed
and the .p2align directive is causing this error. After asking around if
it would be possible to install GAS on this machine I learned that AIX
GNU utils are not maintained as well as the native AIX ones and we
(Red Hat/IBM) have run into issues with the GNU utils in the past and if
possible it would be preferable to be able to use the AIX native
assembler.

Refs: nodejs/node#38512

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #15638)

danbev force-pushed the openssl-3.0-statically-linked branch 2 times, most recently from c75fdea to a8ff58a Compare June 17, 2021 05:06

danbev force-pushed the openssl-3.0-statically-linked branch from ba291ca to a991d15 Compare June 23, 2021 10:15

danbev force-pushed the openssl-3.0-statically-linked branch from 1107e17 to 07ded8b Compare October 10, 2021 13:47

This pull request updates the OpenSSL version that is statically
linked with Node.js from OpenSSl 1.1.1 to quictls OpenSSL 3.0.0+quic.

This pull request will replace the OpenSSL version that is currently
in the deps directory and when performing a normal build
OpenSSL 3.0+quic will be statically linked to the Node.js executable.
We will still be able to dynamically link to OpenSSL 1.1.1 and we have
a CI job which dynamically links to OpenSSL 1.1.1 which is run for
every pull request to make sure that we maintain backward compatibility.

PR-URL: #38512
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>