GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: remove TODOs in `atob` / `btoa` by XadillaX · Pull Request #38548 · nodejs/node

Conversation

@XadillaX

@XadillaX XadillaX commented May 5, 2021

Copy link
Copy Markdown
Contributor

Refs: #38433 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@XadillaX
XadillaX requested a review from jasnell May 5, 2021 07:28
@github-actions github-actions Bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels May 5, 2021
@XadillaX
XadillaX requested a review from addaleax May 5, 2021 07:28
addaleax
addaleax approved these changes May 5, 2021
View reviewed changes
Trott
Trott approved these changes May 6, 2021
View reviewed changes
@Trott

Trott commented May 6, 2021

Copy link
Copy Markdown
Member

Looks good to me, but I wonder if it might be better to replace the comment with something like:

// This implementation is not optimized and should not be.
// Refs: https://github.com/nodejs/node/pull/38433#issuecomment-828426932
XadillaX, addaleax, and trivikr reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@XadillaX
XadillaX requested review from Trott and addaleax May 6, 2021 09:01
addaleax
addaleax approved these changes May 6, 2021
View reviewed changes
jasnell
jasnell approved these changes May 7, 2021
View reviewed changes
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 7, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label May 7, 2021
@nodejs-github-bot

nodejs-github-bot commented May 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37970/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Lxxyx
Lxxyx approved these changes May 7, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37972/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes May 8, 2021
View reviewed changes
trivikr
trivikr approved these changes May 8, 2021
View reviewed changes
@XadillaX @aduh95
buffer: remove TODOs in atob / btoa
0b6f0a0 
Refs: nodejs#38433 (comment)

PR-URL: nodejs#38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@aduh95
aduh95 force-pushed the atob-bta-todo branch from 4f5368e to 0b6f0a0 Compare May 9, 2021 07:11
@aduh95

aduh95 commented May 9, 2021

Copy link
Copy Markdown
Contributor

Landed in 0b6f0a0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 0b6f0a0 into nodejs:master May 9, 2021
targos pushed a commit that referenced this pull request May 17, 2021
@XadillaX @targos
buffer: remove TODOs in atob / btoa
dcae032 
Refs: #38433 (comment)

PR-URL: #38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request May 18, 2021
v16.2.0 release proposal #38719
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@XadillaX @targos
buffer: remove TODOs in atob / btoa
ed76154 
Refs: #38433 (comment)

PR-URL: #38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@XadillaX @targos
buffer: remove TODOs in atob / btoa
536e23f 
Refs: #38433 (comment)

PR-URL: #38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
@XadillaX @targos
buffer: remove TODOs in atob / btoa
6628297 
Refs: #38433 (comment)

PR-URL: #38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jun 6, 2021
v14.17.1 release proposal #38948
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@XadillaX @targos
buffer: remove TODOs in atob / btoa
3c886e0 
Refs: #38433 (comment)

PR-URL: #38548
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@XadillaX @Trott @nodejs-github-bot @aduh95 @jasnell @addaleax @Lxxyx @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.