GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: improve coverage of lib/readline.js by pd4d10 · Pull Request #38646 · nodejs/node

Conversation

pd4d10 commented May 12, 2021

Copy link

Copy Markdown

Contributor

Refs:
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L625
https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L634

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot added needs-ci

PRs that need a full CI run.

test Issues and PRs related to Node.js core tests and test infrastructure. labels

May 12, 2021

pd4d10 force-pushed the patch-test-readline branch from 5917371 to 7489b03 Compare

May 12, 2021 09:25

jasnell approved these changes

May 12, 2021

View reviewed changes

Trott approved these changes

May 13, 2021

View reviewed changes

mhdawson approved these changes

May 14, 2021

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mhdawson commented May 14, 2021

Copy link

Copy Markdown

Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/38092/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 14, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38092/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Lxxyx commented Jun 11, 2021

Copy link

Copy Markdown

Member

Hi, thanks for submitting the code. could you resolve git conflicts? @pd4d10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Lxxyx approved these changes

Jun 11, 2021

View reviewed changes

pd4d10 commented Jun 11, 2021

Copy link

Copy Markdown

Contributor Author

Updated @Lxxyx

Lxxyx reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Lxxyx added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-ci PRs that need a full CI run. labels

Jun 12, 2021

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 12, 2021

nodejs-github-bot commented Jun 12, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38592/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

VoltrexKeyva approved these changes

Sep 3, 2021

View reviewed changes

Lxxyx added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 3, 2021

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 3, 2021

nodejs-github-bot commented Sep 3, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39746/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pd4d10 force-pushed the patch-test-readline branch from 9328554 to 2881cb9 Compare

April 3, 2022 17:21

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare

November 12, 2022 01:49

aduh95 commented May 5, 2024

Copy link

Copy Markdown

Contributor

This needs a rebase

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. label

May 5, 2024

github-actions Bot commented May 5, 2024

Copy link

Copy Markdown

Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          test: improve coverage of lib/readline.js

9b9edd6

pd4d10 force-pushed the patch-test-readline branch from 2881cb9 to 9b9edd6 Compare

May 6, 2024 05:34

pd4d10 commented May 6, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

This needs a rebase

@aduh95 Updated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed stalled Issues and PRs manually marked as stalled and scheduled for automatic closure. labels

May 6, 2024

aduh95 approved these changes

May 10, 2024

View reviewed changes

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 10, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 10, 2024

nodejs-github-bot commented May 10, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59078/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 11, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59089/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 11, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59126/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label

May 12, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

May 12, 2024

nodejs-github-bot merged commit 749b0bf into nodejs:main

May 12, 2024

nodejs-github-bot commented May 12, 2024

Copy link

Copy Markdown

Collaborator

Landed in 749b0bf

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pd4d10 deleted the patch-test-readline branch

May 12, 2024 10:46

targos pushed a commit that referenced this pull request

May 12, 2024


          test: improve coverage of lib/readline.js

ea6070b

PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

targos mentioned this pull request

May 13, 2024

v22.2.0 release proposal #52971

Merged

marco-ippolito mentioned this pull request

Jun 17, 2024

v20.15.0 proposal #53486

Merged

marco-ippolito pushed a commit that referenced this pull request

Jun 17, 2024


          test: improve coverage of lib/readline.js

0be8123

PR-URL: #38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

soophoo pushed a commit to soophoo/node that referenced this pull request

Jun 20, 2024


          test: improve coverage of lib/readline.js

c1eb445

PR-URL: nodejs#38646
Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

Reviewers

jasnell

jasnell approved these changes

Trott

Trott approved these changes

Lxxyx

Lxxyx approved these changes

aduh95

aduh95 approved these changes

+2 more reviewers

mhdawson

mhdawson approved these changes

VoltrexKeyva

VoltrexKeyva approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

pd4d10 commented May 12, 2021

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented May 14, 2021

Uh oh!

nodejs-github-bot commented May 14, 2021

Uh oh!

Lxxyx commented Jun 11, 2021

Uh oh!

pd4d10 commented Jun 11, 2021

Uh oh!

nodejs-github-bot commented Jun 12, 2021

Uh oh!

nodejs-github-bot commented Sep 3, 2021

Uh oh!

aduh95 commented May 5, 2024

Uh oh!

github-actions Bot commented May 5, 2024

Uh oh!

pd4d10 commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 10, 2024

Uh oh!

nodejs-github-bot commented May 11, 2024

Uh oh!

nodejs-github-bot commented May 11, 2024

Uh oh!

nodejs-github-bot commented May 12, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pd4d10 commented May 6, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.