GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify module loading behavior by cjihrig · Pull Request #3920 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Nov 19, 2015

Copy link
Copy Markdown
Contributor

The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig cjihrig mentioned this pull request Nov 19, 2015
Module loading implementation does not match API docs #3873
Closed
@jasnell

jasnell commented Nov 19, 2015

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added doc Issues and PRs related to Node.js documentation. lts-watch-v4.x labels Nov 19, 2015
@targos

targos commented Nov 19, 2015

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Nov 19, 2015
cjihrig added a commit that referenced this pull request Nov 19, 2015
@cjihrig
doc: clarify module loading behavior
5900d14 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@cjihrig cjihrig closed this Nov 19, 2015
@cjihrig
cjihrig force-pushed the lookup-docs branch from 7eedeb8 to 5900d14 Compare November 19, 2015 18:12
@cjihrig
cjihrig deleted the lookup-docs branch November 19, 2015 18:12
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
deps: upgrade npm to 3.5.0 #4032
Closed
cjihrig added a commit that referenced this pull request Dec 1, 2015
@cjihrig Myles Borins
doc: clarify module loading behavior
ebf072a 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins added lts-landed-on-v4.x and removed lts-watch-v4.x labels Dec 1, 2015
cjihrig added a commit that referenced this pull request Dec 4, 2015
@cjihrig @rvagg
doc: clarify module loading behavior
13e8b84 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
cjihrig added a commit that referenced this pull request Dec 5, 2015
@cjihrig @rvagg
doc: clarify module loading behavior
bbcb2a2 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Dec 8, 2015
Release proposal: v5.2.0 #4180
Closed
Release proposal: v5.2.0 (Stable) #4181
Merged
@MylesBorins MylesBorins added land-on-v4.x and removed lts-landed-on-v4.x labels Dec 17, 2015
@jasnell jasnell mentioned this pull request Dec 17, 2015
Release 4.2.4 Planning #4321
Closed
cjihrig added a commit that referenced this pull request Dec 17, 2015
@cjihrig @jasnell
doc: clarify module loading behavior
4bc71e0 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
cjihrig added a commit that referenced this pull request Dec 23, 2015
@cjihrig @jasnell
doc: clarify module loading behavior
ad02f0e 
The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873
PR-URL: #3920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@cjihrig @jasnell @targos @mscdex @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.