GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: make scripts in gyp run with right python by zcbenz · Pull Request #39730 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Should use <(python) instead of python for scripts in gyp files, otherwise the scripts might be run with python2 on some environments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@zcbenz
build: make scripts in gyp run with right python
f14e371
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 11, 2021
targos
targos approved these changes Aug 11, 2021
View reviewed changes
addaleax
addaleax approved these changes Aug 11, 2021
View reviewed changes
legendecas
legendecas approved these changes Aug 11, 2021
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 12, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 12, 2021
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39547/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 12, 2021
View reviewed changes
lpinca
lpinca approved these changes Aug 13, 2021
View reviewed changes
@Ayase-252 Ayase-252 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 26, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2021
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40079/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40238/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 9, 2021
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 9, 2021
@github-actions

github-actions Bot commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

Landed in a3c0713...92090d3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Oct 9, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
@zcbenz @nodejs-github-bot
build: make scripts in gyp run with right python
92090d3 
PR-URL: #39730
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 13, 2021
@zcbenz @targos
build: make scripts in gyp run with right python
2de57ed 
PR-URL: #39730
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
2021-10-19, Version 17.0.0 (Current) #40119
Merged
2 tasks done
@richardlau richardlau mentioned this pull request Oct 18, 2021
v16.12.0 proposal #40504
Merged
@gengjiawen gengjiawen mentioned this pull request Nov 12, 2022
build: make scripts in gyp run with right python #45435
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@zcbenz @nodejs-github-bot @jasnell @addaleax @lpinca @targos @legendecas @Ayase-252 @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.