GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: Replace sane with reasonable by lewiscowper · Pull Request #3980 · nodejs/node

Conversation

@lewiscowper

@lewiscowper lewiscowper commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

I noticed this slip when reading about modules, and thought I'd pop a PR in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ChALkeR ChALkeR added the doc Issues and PRs related to Node.js documentation. label Nov 23, 2015
@ChALkeR

ChALkeR commented Nov 23, 2015

Copy link
Copy Markdown
Member

The correct prefix for the commit title would be «doc: », not «docs: ».
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Nov 23, 2015
@evanlucas

evanlucas commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

LGTM with what @ChALkeR said
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Nov 23, 2015

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lewiscowper
doc: Replace sane with reasonable
9558d59 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.
@lewiscowper
lewiscowper force-pushed the language-tweak branch from b6682f0 to 9558d59 Compare November 23, 2015 09:20
@lewiscowper

lewiscowper commented Nov 23, 2015

Copy link
Copy Markdown
Contributor Author

Pushed new prefix now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lewiscowper lewiscowper changed the title docs: Replace sane with reasonable doc: Replace sane with reasonable Nov 23, 2015
@cjihrig

cjihrig commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit to targos/node that referenced this pull request Nov 23, 2015
@lewiscowper @targos
doc: replace sane with reasonable
3becac2 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: nodejs#3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos

targos commented Nov 23, 2015

Copy link
Copy Markdown
Member

landed in 3becac2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Nov 23, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
deps: upgrade npm to 3.5.0 #4032
Closed
@jasnell jasnell added the lts-watch-v4.x label Nov 30, 2015
MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
@lewiscowper Myles Borins
doc: replace sane with reasonable
10cd439 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added lts-landed-on-v4.x and removed lts-watch-v4.x labels Dec 1, 2015
rvagg pushed a commit that referenced this pull request Dec 4, 2015
@lewiscowper @rvagg
doc: replace sane with reasonable
ed18135 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
@lewiscowper @rvagg
doc: replace sane with reasonable
4602e01 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 8, 2015
Release proposal: v5.2.0 #4180
Closed
Release proposal: v5.2.0 (Stable) #4181
Merged
@MylesBorins MylesBorins added land-on-v4.x and removed lts-landed-on-v4.x labels Dec 17, 2015
@jasnell jasnell mentioned this pull request Dec 17, 2015
Release 4.2.4 Planning #4321
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
@lewiscowper @jasnell
doc: replace sane with reasonable
6ef3625 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
@lewiscowper @jasnell
doc: replace sane with reasonable
4008e75 
Removing ableist language because we don't need to make the comparison
to people with mental health issues to get our point across.

PR-URL: #3980
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@lewiscowper @ChALkeR @evanlucas @targos @cjihrig @mscdex @jasnell @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.