GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: re-implement lint-md without unified-args by Trott · Pull Request #40180 · nodejs/node

Conversation

@Trott

@Trott Trott commented Sep 22, 2021

Copy link
Copy Markdown
Member

unified-args ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes unified-args. This means the preset settings are
now respected and it removes nearly over 28000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
node_modules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Sep 22, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 22, 2021
@Trott Trott mentioned this pull request Sep 22, 2021
tools: implement markdown formatting #40181
Merged
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 22, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 approved these changes Sep 22, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Sep 23, 2021
CI Reliability 2021-09-23 nodejs/reliability#66
Open
18 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40038/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Trott force-pushed the de-rollup-again branch from 0cf5936 to 84981f3 Compare September 23, 2021 06:17
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
Trott force-pushed the de-rollup-again branch from 84981f3 to cc5807d Compare September 23, 2021 06:28
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott
tools: re-implement lint-md without unified-args
4bbb621 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.
@Trott
Trott force-pushed the de-rollup-again branch from cc5807d to 4bbb621 Compare September 23, 2021 06:31
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40042/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40046/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Sep 23, 2021
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 23, 2021
This was referenced Sep 24, 2021
CI Reliability 2021-09-24 nodejs/reliability#67
Open
CI Reliability 2021-09-25 nodejs/reliability#68
Open
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 25, 2021
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 25, 2021
@github-actions

github-actions Bot commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

Landed in 8006586...8d83c47
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Sep 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 25, 2021
@Trott @nodejs-github-bot
tools: re-implement lint-md without unified-args
8d83c47 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: #40180
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 26, 2021
CI Reliability 2021-09-26 nodejs/reliability#69
Open
CI Reliability 2021-09-27 nodejs/reliability#70
Open
CI Reliability 2021-09-28 nodejs/reliability#71
Open
CI Reliability 2021-09-29 nodejs/reliability#72
Open
CI Reliability 2021-09-30 nodejs/reliability#73
Open
CI Reliability 2021-10-01 nodejs/reliability#74
Open
CI Reliability 2021-10-02 nodejs/reliability#75
Open
@github-actions github-actions Bot mentioned this pull request Oct 3, 2021
CI Reliability 2021-10-03 nodejs/reliability#76
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 4, 2021
@Trott @targos
tools: re-implement lint-md without unified-args
67812e8 
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.

PR-URL: #40180
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
v16.11.0 release proposal #40319
Merged
@Trott
Trott deleted the de-rollup-again branch September 25, 2022 17:13
@avivkeller avivkeller mentioned this pull request Oct 4, 2024
build: stop pre-compiling lint-md #55266
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @nodejs-github-bot @jasnell @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.