GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: use .mailmap to consolidate AUTHORS entries for ide by Trott · Pull Request #40367 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member

James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 7, 2021
@Trott

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

@ide This removes your expo.io email from AUTHORS and leaves your jameside.com email there. (Currently both are in the file.) If you'd prefer it the other way around (leave expo.io and remove jameside.com) or a third email address to replace both entries, please leave a comment. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 7, 2021
View reviewed changes
@ide

ide commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Could you please change the expo.io email to expo.dev? Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

Could you please change the expo.io email to expo.dev? Thank you!

Ultimately, what's the one email address you want to show up in AUTHORS? Is it this?:

James Ide <[email protected]>

Or this?:

James Ide <[email protected]>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ide

ide commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Could you please use the jameside.com domain? Thank you!
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 8, 2021

Copy link
Copy Markdown
Member Author

Could you please use the jameside.com domain? Thank you!

OK, cool, that's what this change does. (I can't change the expo.io to expo.dev because that's a .mailmap entry. If I change it, then it won't change your expo.io email in the git log to jameside.com and the expo.io entry will start showing up in AUTHORS again. What that entry says is "Wherever you see this expo.io email in the git log, treat it as this jameside.com email instead.")
ide reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 8, 2021
@github-actions

github-actions Bot commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
lpinca and Lxxyx reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 8, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Oct 9, 2021
View reviewed changes
@Trott
meta: use .mailmap to consolidate AUTHORS entries for ide
6a205d7 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: nodejs#40367
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@Trott
Trott force-pushed the mailmap-ji branch from 0670962 to 6a205d7 Compare October 9, 2021 15:08
@Trott

Trott commented Oct 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 6a205d7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 6a205d7 into nodejs:master Oct 9, 2021
@Trott
Trott deleted the mailmap-ji branch October 9, 2021 15:08
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
meta: use .mailmap to consolidate AUTHORS entries for ide
5668182 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: #40367
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
2021-10-19, Version 17.0.0 (Current) #40119
Merged
2 tasks done
@richardlau richardlau mentioned this pull request Oct 18, 2021
v16.12.0 proposal #40504
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @ide @jasnell @lpinca @Lxxyx @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.