GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: make V8 9.5 ABI-compatible with 9.6 by targos · Pull Request #40422 · nodejs/node

Conversation

@targos

@targos targos commented Oct 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and lin7sh reacted with thumbs up emoji lin7sh and bricss reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🚀 2 reactions
@targos
targos requested review from MylesBorins and removed request for MylesBorins October 12, 2021 06:53
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 12, 2021
@targos
targos force-pushed the v8-95-96 branch from 4c60d4e to d8b131a Compare October 12, 2021 06:54
@targos targos added dont-land-on-v12.x labels Oct 12, 2021
aduh95
aduh95 approved these changes Oct 12, 2021
View reviewed changes
This was referenced Oct 12, 2021
Node.js Technical Steering Committee (TSC) Meeting 2021-10-14 nodejs/TSC#1098
Closed
2021-10-19, Version 17.0.0 (Current) #40119
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2021 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40255/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4321/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 12, 2021
@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021
@github-actions github-actions Bot mentioned this pull request Oct 13, 2021
CI Reliability 2021-10-13 nodejs/reliability#85
Open
22 tasks
@targos

targos commented Oct 13, 2021

Copy link
Copy Markdown
Member Author 
20:24:34 ../../src/codegen/ppc/macro-assembler-ppc.cc:3642:39: error: ‘builtin_entry_slot_offset’ is not a member of ‘v8::internal::IsolateData’
20:24:34                           IsolateData::builtin_entry_slot_offset(target)));
20:24:34                                        ^~~~~~~~~~~~~~~~~~~~~~~~~

Looks like I need to cherry-pick platform-specific changes. I'll do that later today.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
deps: V8: make V8 9.5 ABI-compatible with 9.6
60622aa 
Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf
@targos
targos force-pushed the v8-95-96 branch from d8b131a to 60622aa Compare October 13, 2021 08:55
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2021 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40278/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4324/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40288/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs
BethGriggs approved these changes Oct 13, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40293/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 14, 2021
CI Reliability 2021-10-14 nodejs/reliability#86
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40295/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40297/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Oct 14, 2021

Copy link
Copy Markdown
Member Author

Landed in 795108a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Oct 14, 2021
@targos
targos deleted the v8-95-96 branch October 14, 2021 06:43
targos added a commit that referenced this pull request Oct 14, 2021
@targos
deps: V8: make V8 9.5 ABI-compatible with 9.6
795108a 
Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf

PR-URL: #40422
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 15, 2021
CI Reliability 2021-10-15 nodejs/reliability#87
Open
23 tasks
This was referenced Oct 16, 2021
CI Reliability 2021-10-16 nodejs/reliability#88
Open
CI Reliability 2021-10-17 nodejs/reliability#89
Open
CI Reliability 2021-10-18 nodejs/reliability#90
Open
CI Reliability 2021-10-19 nodejs/reliability#91
Open
CI Reliability 2021-10-20 nodejs/reliability#92
Open
CI Reliability 2021-10-21 nodejs/reliability#93
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@targos @nodejs-github-bot @BethGriggs @aduh95 @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.