GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: update V8 to 9.6 by targos · Pull Request #40488 · nodejs/node

Conversation

targos commented Oct 17, 2021

Copy link

Copy Markdown

Member

Blog post: https://v8.dev/blog/v8-release-96

ETA: Tue, Nov 16, 2021.

Diff in public V8 headers: https://gist.github.com/targos/fb358c24624eee2bf8b5350d39e852a0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, lin7sh, dnalborczyk, and lin72h reacted with thumbs up emoji

bricss, lin7sh, dnalborczyk, and lin72h reacted with hooray emoji

bricss, lin7sh, dnalborczyk, and lin72h reacted with heart emoji

bricss, lin7sh, dnalborczyk, and lin72h reacted with rocket emoji

All reactions

👍 4 reactions
🎉 4 reactions
❤️ 4 reactions
🚀 4 reactions

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label

Oct 17, 2021

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v8 engine Issues and PRs related to the V8 dependency. labels

Oct 17, 2021

nodejs-github-bot commented Oct 17, 2021 •

edited by targos

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40335/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4333/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 17, 2021

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 17, 2021

nodejs-github-bot commented Oct 17, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40336/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Oct 17, 2021

Copy link

Copy Markdown

Member Author

@nodejs/platform-windows-arm Can you please help with the build failure on arm64?

I tried to make our GYP config closer to the GN one, but it's still failing

4d1e094
https://ci.nodejs.org/job/node-compile-windows/42438/nodes=win-vs2019-arm64/console

14:25:53      Creating library ..\..\out\Release\mksnapshot_host.lib and object ..\..\out\Release\mksnapshot_host.exp
14:25:59 v8_base_without_compiler_host.lib(api.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::TryHandleWasmTrap(struct _EXCEPTION_POINTERS *)" (?TryHandleWasmTrap@trap_handler@internal@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) referenced in function "bool __cdecl v8::TryHandleWebAssemblyTrapWindows(struct _EXCEPTION_POINTERS *)" (?TryHandleWebAssemblyTrapWindows@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(handler-outside.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::RegisterDefaultTrapHandler(void)" (?RegisterDefaultTrapHandler@trap_handler@internal@v8@@YA_NXZ) referenced in function "bool __cdecl v8::internal::trap_handler::EnableTrapHandler(bool)" (?EnableTrapHandler@trap_handler@internal@v8@@YA_N_N@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(simulator-arm64.obj) : error LNK2019: unresolved external symbol ProbeMemory referenced in function "protected: void __cdecl v8::internal::Simulator::LoadStoreHelper(class v8::internal::Instruction *,__int64,enum v8::internal::AddrMode)" (?LoadStoreHelper@Simulator@internal@v8@@IEAAXPEAVInstruction@23@_JW4AddrMode@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00     Hint on symbols that are defined and could potentially match:
14:26:00       "protected: bool __cdecl v8::internal::Simulator::ProbeMemory(unsigned __int64,unsigned __int64)" (?ProbeMemory@Simulator@internal@v8@@IEAA_N_K0@Z)
14:26:00 ..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 3 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 18, 2021

CI Reliability 2021-10-18 nodejs/reliability#90

Open

CI Reliability 2021-10-19 nodejs/reliability#91

Open

targos commented Oct 19, 2021

Copy link

Copy Markdown

Member Author

I'm pretty sure the problem is that handler-outside-win.cc' is not being compiled, so something is wrong with the gyp condition.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 19, 2021

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 19, 2021

nodejs-github-bot commented Oct 19, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40360/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Oct 19, 2021

Copy link

Copy Markdown

Member Author

I opened a V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=12327

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos marked this pull request as draft

October 19, 2021 18:18

targos commented Oct 19, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Trying a new build which will hopefully log the values of some macros: https://ci.nodejs.org/job/node-test-commit-windows-fanned/44944/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44945/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44946/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos force-pushed the v8-96 branch from ea98767 to 3805af4 Compare

October 19, 2021 19:25

nodejs-github-bot commented Oct 19, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40373/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos force-pushed the v8-96 branch from 632ca2b to 2f28851 Compare

October 19, 2021 21:51

nodejs-github-bot commented Oct 19, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40374/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos force-pushed the v8-96 branch from 2f28851 to 5dae1db Compare

October 19, 2021 22:02

nodejs-github-bot commented Oct 19, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40375/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Oct 19, 2021

Copy link

Copy Markdown

Member Author

So, we've got a problem with gyp that I have no idea how to solve:

https://github.com/targos/node/blob/5dae1dba882f6ce71016a7b08f7f120e3015b342/tools/v8_gypfiles/v8.gyp#L871

With conditions, _toolset is not defined, because toolsets is defined conditionally (it has to be).
With target_conditions, _toolset is defined, but host_arch is not.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos force-pushed the v8-96 branch from 5dae1db to b756cd2 Compare

October 19, 2021 22:52

nodejs-github-bot commented Oct 19, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40376/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Oct 20, 2021

CI Reliability 2021-10-20 nodejs/reliability#92

Open

27 tasks

targos force-pushed the v8-96 branch from b756cd2 to cb72644 Compare

October 20, 2021 06:28

nodejs-github-bot commented Oct 20, 2021

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40379/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Nov 30, 2021


          deps: disable trap handler for Windows cross-compiler

732490a

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos added a commit that referenced this pull request

Nov 30, 2021


          2021-11-30, Version 17.2.0 (Current)

79731df

Notable changes:

async_hooks:
  * (SEMVER-MINOR) expose async_wrap providers (Rafael Gonzaga) #40760
deps:
  * (SEMVER-MINOR) update V8 to 9.6.180.14 (Michaël Zasso) #40488
lib:
  * (SEMVER-MINOR) add reason to AbortSignal (James M Snell) #40807
src:
  * (SEMVER-MINOR) add x509.fingerprint512 to crypto module (3nprob) #39809
stream:
  * deprecate thenable support (Antoine du Hamel) #40860
  * fix finished regression when working with legacy Stream (Matteo Collina) #40858

PR-URL: #40983

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 1, 2021


          deps: disable trap handler for Windows cross-compiler

a0f1aa1

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 2, 2021


          deps: disable trap handler for Windows cross-compiler

36ff815

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 3, 2021


          deps: disable trap handler for Windows cross-compiler

007d90e

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 4, 2021


          deps: disable trap handler for Windows cross-compiler

1b5393e

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 5, 2021


          deps: disable trap handler for Windows cross-compiler

ffbbd83

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 6, 2021


          deps: disable trap handler for Windows cross-compiler

cc3c121

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 7, 2021


          deps: disable trap handler for Windows cross-compiler

e30493e

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 8, 2021


          deps: disable trap handler for Windows cross-compiler

fe1fd5d

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 9, 2021


          deps: disable trap handler for Windows cross-compiler

608234c

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos added a commit that referenced this pull request

Dec 9, 2021


          deps: disable trap handler for Windows cross-compiler

96b606f

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 10, 2021


          deps: disable trap handler for Windows cross-compiler

7c9132b

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 11, 2021


          deps: disable trap handler for Windows cross-compiler

1fb1984

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 12, 2021


          deps: disable trap handler for Windows cross-compiler

53ea8e6

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 13, 2021


          deps: disable trap handler for Windows cross-compiler

7b72e5a

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 14, 2021


          deps: disable trap handler for Windows cross-compiler

d746f30

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos added a commit that referenced this pull request

Dec 15, 2021


          deps: disable trap handler for Windows cross-compiler

fa86751

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: #40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 15, 2021


          deps: disable trap handler for Windows cross-compiler

f5673e5

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 16, 2021


          deps: disable trap handler for Windows cross-compiler

1af563a

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 17, 2021


          deps: disable trap handler for Windows cross-compiler

bac3e4b

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request

Dec 18, 2021


          deps: disable trap handler for Windows cross-compiler

f1adfd7

`handler-outside-simulator.cc` uses inline assembly, which is not
supported by MSVC.

PR-URL: nodejs/node#40488
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>

hexchain mentioned this pull request

Jan 3, 2022

`node --help' crashes inside qemu-user in 17.2.0 riscv-collab/v8#517

Closed

RaisinTen mentioned this pull request

May 30, 2022

[v16.x backport] tools: update V8 gypfiles for 9.6 #43247

Closed

bengl mentioned this pull request

May 31, 2022

v18.3.0 proposal #43266

Merged

This was referenced May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

v16.15.1 proposal #43272

Merged

krk mentioned this pull request

Dec 30, 2022

Performance regression in Buffer.concat #45802

Closed

This was referenced Jan 28, 2025

chore(deps): update node.js to v16.15.1 - autoclosed opalmedapps/docs#22

Closed

chore: update software packages (patch) opalmedapps/docs#27

Closed

Reviewers

jasnell

jasnell approved these changes

gengjiawen

gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

semver-minor

PRs that contain new features and should be released in the next minor version.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

targos commented Oct 17, 2021

Uh oh!

nodejs-github-bot commented Oct 17, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 17, 2021

Uh oh!

targos commented Oct 17, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 20, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nodejs-github-bot commented Oct 17, 2021 •

edited by targos

Loading

Uh oh!

There was an error while loading. Please reload this page.

targos commented Oct 19, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.