GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: simplify major release preparation by BethGriggs · Pull Request #40816 · nodejs/node

Conversation

@BethGriggs

@BethGriggs BethGriggs commented Nov 15, 2021

Copy link
Copy Markdown
Member

Proposed simplification of the major release process.

Changes/rational:

  • Change the branch creation to two months prior from three months prior.
    • No builds are run until 6 weeks before so there's no significant impact of creating the branches any earlier.
  • Do not cherry-pick commits within the last month. Mirror the master branch up until 1 week before the release.
    • Mirroring the branches for as long as possible keeps the Git history in sync.
  • Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'.
    • Majors are already gated with TSC approvals at land time.
    • We've had almost no objections for majors for the past few releases - and when there is an objection we have almost always reverted on master too.
    • Asking if there's any objections to the majors is a somewhat tiresome process, and in recent releases I've found there has been minimal engagement. (We're all busy people and it is easy to miss notifications.)

cc: @nodejs/releasers @nodejs/tsc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina and dnalborczyk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
Trott
Trott approved these changes Nov 15, 2021
View reviewed changes
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 15, 2021
mcollina
mcollina approved these changes Nov 15, 2021
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjihrig
cjihrig approved these changes Nov 15, 2021
View reviewed changes
richardlau
richardlau approved these changes Nov 15, 2021
View reviewed changes
aduh95
aduh95 approved these changes Nov 15, 2021
View reviewed changes
Comment thread doc/guides/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
danielleadams
danielleadams approved these changes Nov 15, 2021
View reviewed changes
ronag
ronag approved these changes Nov 15, 2021
View reviewed changes
@BethGriggs BethGriggs added the release-agenda Issues and PRs to discuss during Release team meetings. label Nov 16, 2021
mhdawson
mhdawson approved these changes Nov 16, 2021
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tniessen
tniessen approved these changes Nov 17, 2021
View reviewed changes
@BethGriggs BethGriggs mentioned this pull request Nov 17, 2021
Node.js Release WorkGroup Meeting 2021-11-18 nodejs/Release#712
Closed
@BethGriggs
doc: simplify major release preparation
068abb6 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.
@BethGriggs
BethGriggs force-pushed the major-releases-edits branch from 0b48519 to 068abb6 Compare November 23, 2021 10:20
danielleadams
danielleadams approved these changes Nov 27, 2021
View reviewed changes
@BethGriggs BethGriggs added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 8, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 8, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 18ff583 into nodejs:master Dec 8, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2021

Copy link
Copy Markdown
Collaborator

Landed in 18ff583
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@BethGriggs @danielleadams
doc: simplify major release preparation
e3ac384 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
v17.3.0 release proposal #41167
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
2fbd3d9 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
a328f59 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@BethGriggs @danielleadams
doc: simplify major release preparation
e401e6c 
Changes/rational:

- Change the branch creation to two months prior from three months prior
  to the release.
- Do not cherry-pick commits within the last month - mirror the master
  branch up until 1 week before the release.
- Dropped 'semver major cut-off' and replace with 'Inform TSC of any
  majors which land within a month of the release'.

PR-URL: #40816
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
@BethGriggs BethGriggs mentioned this pull request Mar 9, 2022
2022-04-19, Version 18.0.0 (Current) #42262
Merged
@RafaelGSS RafaelGSS mentioned this pull request Sep 13, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@BethGriggs
BethGriggs deleted the major-releases-edits branch March 6, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@ronag ronag ronag approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@danielleadams danielleadams danielleadams approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. release-agenda Issues and PRs to discuss during Release team meetings.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@BethGriggs @nodejs-github-bot @mcollina @Trott @cjihrig @ronag @tniessen @richardlau @danielleadams @mhdawson @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.