GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: deflake cluster-concurrent-disconnect by lpinca · Pull Request #40877 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Nov 19, 2021

Copy link
Copy Markdown
Member

Occasionally the error code is 'ENOTCONN' on macOS. Add it as an
allowed/expected code.

Fixes: #38405

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 19, 2021
@lpinca

lpinca commented Nov 19, 2021

Copy link
Copy Markdown
Member Author

Before:

$ ./tools/test.py -J --repeat=1000 test/parallel/test-cluster-concurrent-disconnect.js 
=== release test-cluster-concurrent-disconnect ===                   
Path: parallel/test-cluster-concurrent-disconnect
node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'ENOTCONN'
- 'EPIPE'
    at Worker.<anonymous> (/Users/luigi/code/node/test/parallel/test-cluster-concurrent-disconnect.js:29:14)
    at Worker.emit (node:events:390:28)
    at ChildProcess.<anonymous> (node:internal/cluster/worker:30:12)
    at ChildProcess.emit (node:events:390:28)
    at node:internal/child_process:848:39
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'ENOTCONN',
  expected: 'EPIPE',
  operator: 'strictEqual'
}

...

[02:12|% 100|+ 992|-   8]: Done

After:

$ ./tools/test.py -J --repeat=1000 test/parallel/test-cluster-concurrent-disconnect.js 
[02:14|% 100|+ 1000|-   0]: Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos
targos approved these changes Nov 19, 2021
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40991/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40998/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott
Trott approved these changes Nov 19, 2021
View reviewed changes
tniessen
tniessen approved these changes Nov 19, 2021
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this only be lenient on mac?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lpinca

lpinca commented Nov 19, 2021

Copy link
Copy Markdown
Member Author

Should this only be lenient on mac?

I think it makes sense. Will update.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca
test: deflake cluster-concurrent-disconnect
4e346e8
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: nodejs#38405
@lpinca
lpinca force-pushed the deflake/cluster-concurrent-disconnect branch from 3bb5ba1 to 4e346e8 Compare November 19, 2021 20:23
This was referenced Nov 20, 2021
CI Reliability 2021-11-20 nodejs/reliability#123
Open
CI Reliability 2021-11-21 nodejs/reliability#124
Open
ZYSzys
ZYSzys approved these changes Nov 21, 2021
View reviewed changes
@ZYSzys ZYSzys added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 21, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41024/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tniessen
tniessen approved these changes Nov 21, 2021
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41034/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 977877b into nodejs:master Nov 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2021

Copy link
Copy Markdown
Collaborator

Landed in 977877b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca
lpinca deleted the deflake/cluster-concurrent-disconnect branch November 21, 2021 20:44
This was referenced Nov 22, 2021
CI Reliability 2021-11-22 nodejs/reliability#125
Open
CI Reliability 2021-11-23 nodejs/reliability#126
Open
CI Reliability 2021-11-24 nodejs/reliability#127
Open
CI Reliability 2021-11-25 nodejs/reliability#128
Open
@github-actions github-actions Bot mentioned this pull request Nov 26, 2021
CI Reliability 2021-11-26 nodejs/reliability#129
Open
33 tasks
targos pushed a commit that referenced this pull request Nov 26, 2021
@lpinca @targos
test: deflake cluster-concurrent-disconnect
4288c6a
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos targos mentioned this pull request Nov 26, 2021
v17.2.0 release proposal #40983
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@lpinca @danielleadams
test: deflake cluster-concurrent-disconnect
36c29e9
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@lpinca @danielleadams
test: deflake cluster-concurrent-disconnect
ab398b6
Occasionally the error code is `'ENOTCONN'` on macOS. Add it as an
allowed/expected code.

Fixes: #38405

PR-URL: #40877
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
@daeyeon daeyeon mentioned this pull request Jul 23, 2022
test: fix test-cluster-concurrent-disconnect #43961
Merged
@robobun robobun mentioned this pull request Aug 30, 2026
child_process: report a failed child stdin write with syscall write, as Node does oven-sh/bun#40935
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@tniessen tniessen tniessen approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-cluster-concurrent-disconnect

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@lpinca @nodejs-github-bot @Trott @targos @tniessen @ZYSzys
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.