GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: improve readability of texts in workflows by Mesteery · Pull Request #40988 · nodejs/node

Conversation

@Mesteery

@Mesteery Mesteery commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 26, 2021
@Mesteery Mesteery mentioned this pull request Nov 26, 2021
build: update actions file #39871
Closed
lpinca
lpinca reviewed Nov 27, 2021
View reviewed changes
Comment thread .github/workflows/close-stalled.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

targos
targos reviewed Dec 15, 2021
View reviewed changes
Comment thread .github/workflows/comment-labeled.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

targos
targos approved these changes Dec 15, 2021
View reviewed changes
@Mesteery Mesteery added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 15, 2021
jasnell
jasnell approved these changes Dec 17, 2021
View reviewed changes
@targos targos added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 17, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 17, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 17, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/40988
✔  Done loading data for nodejs/node/pull/40988
----------------------------------- PR info ------------------------------------
Title      build: improve readability of texts in workflows (#40988)
Author     Mestery  (@Mesteery)
Branch     Mesteery:actions-text-lisibility -> nodejs:master
Labels     meta, author ready, commit-queue-squash
Commits    6
 - build: improve readability of texts in workflows
 - Update close-stalled.yml
 - Merge branch 'master' into actions-text-lisibility
 - Update comment-labeled.yml
 - Update close-stalled.yml
 - Update comment-labeled.yml
Committers 2
 - Mestery 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40988
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 26 Nov 2021 21:42:25 GMT
   ✔  Approvals: 2
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40988#pullrequestreview-832411116
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40988#pullrequestreview-835355041
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 40988
From https://github.com/nodejs/node
 * branch                  refs/pull/40988/merge -> FETCH_HEAD
✔  Fetched commits as c8f5dd64b157..3214e0eb5536
--------------------------------------------------------------------------------
Auto-merging .github/workflows/authors.yml
Auto-merging .github/workflows/close-stalled.yml
Auto-merging .github/workflows/comment-labeled.yml
CONFLICT (content): Merge conflict in .github/workflows/comment-labeled.yml
Auto-merging .github/workflows/license-builder.yml
error: could not apply cc3df1d1c3... build: improve readability of texts in workflows
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✖  Failed to apply patches
https://github.com/nodejs/node/actions/runs/1593003553
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 17, 2021
@targos

targos commented Dec 17, 2021

Copy link
Copy Markdown
Member

@Mesteery I think this fails to land automatically because of the merge commit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Mesteery
build: improve readability of texts in workflows
d3419ae
@Mesteery
Mesteery force-pushed the actions-text-lisibility branch from 3214e0e to d3419ae Compare December 17, 2021 17:00
@Mesteery Mesteery removed the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Dec 17, 2021
@jasnell jasnell removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 19, 2021
jasnell
jasnell approved these changes Dec 19, 2021
View reviewed changes
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 19, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 665b404 into nodejs:master Dec 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator

Landed in 665b404

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Jan 14, 2022
@Mesteery @targos
build: improve readability of texts in workflows
011c5f6
PR-URL: #40988
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Mesteery @danielleadams
build: improve readability of texts in workflows
79f7e5b
PR-URL: #40988
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Mesteery @danielleadams
build: improve readability of texts in workflows
c10fcb1
PR-URL: #40988
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments
@jasnell jasnell jasnell approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Mesteery @nodejs-github-bot @targos @jasnell @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.