GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: add types for symbol and accessor properties on `primordials` by ExE-Boss · Pull Request #40992 · nodejs/node

Conversation

@ExE-Boss

@ExE-Boss ExE-Boss commented Nov 27, 2021

Copy link
Copy Markdown
Contributor

I also fixed the types of primordials.uncurryThis and primordials.AsyncIteratorPrototype, added %TypedArray% statics, and made global properties use:

export import NAME = globalThis.NAME;

In order to re‑export types as well as values.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Nov 27, 2021
@ExE-Boss
ExE-Boss force-pushed the typings/primordials/add-symbol-and-accessor-properties branch from 686be5a to f4c00aa Compare November 27, 2021 14:03
@ExE-Boss ExE-Boss changed the title typings(primordials): Add types for symbol and accessor properties typings: Add types for symbol and accessor properties on primordials Nov 27, 2021
@ExE-Boss
typings: add types for symbol and accessor properties on primordials
b2b15f1
@ExE-Boss
ExE-Boss force-pushed the typings/primordials/add-symbol-and-accessor-properties branch from f4c00aa to b2b15f1 Compare November 27, 2021 14:04
@ExE-Boss ExE-Boss changed the title typings: Add types for symbol and accessor properties on primordials typings: add types for symbol and accessor properties on primordials Nov 27, 2021
@aduh95

aduh95 commented Nov 29, 2021

Copy link
Copy Markdown
Contributor

made global properties use:

export import NAME = globalThis.NAME;

In order to re‑export types as well as values.

Does this matter in a .d.ts file? My understanding was we were only dealing with types in those files, not values.
ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Nov 29, 2021
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 30, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 30, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/40992
✔  Done loading data for nodejs/node/pull/40992
----------------------------------- PR info ------------------------------------
Title      typings: add types for symbol and accessor properties on `primordials` (#40992)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ExE-Boss:typings/primordials/add-symbol-and-accessor-properties -> nodejs:master
Labels     typings
Commits    1
 - typings: add types for symbol and accessor properties on `primordials`
Committers 1
 - ExE Boss 
PR-URL: https://github.com/nodejs/node/pull/40992
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40992
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 27 Nov 2021 14:01:05 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40992#pullrequestreview-817916369
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1639087835
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 30, 2021
@aduh95
aduh95 merged commit c93ba41 into nodejs:master Dec 30, 2021
@aduh95

aduh95 commented Dec 30, 2021

Copy link
Copy Markdown
Contributor

Landed in c93ba41
ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ExE-Boss
ExE-Boss deleted the typings/primordials/add-symbol-and-accessor-properties branch December 31, 2021 10:44
targos pushed a commit that referenced this pull request Jan 14, 2022
@ExE-Boss @targos
typings: add types for symbol and accessor properties on primordials
c8e8fc0 
PR-URL: #40992
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@ExE-Boss @danielleadams
typings: add types for symbol and accessor properties on primordials
88a93e5 
PR-URL: #40992
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ExE-Boss @danielleadams
typings: add types for symbol and accessor properties on primordials
5380de7 
PR-URL: #40992
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ExE-Boss @aduh95 @nodejs-github-bot @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.