GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve test coverage of dns/promises by kuriyosh · Pull Request #41133 · nodejs/node

Conversation

@kuriyosh

@kuriyosh kuriyosh commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

This improves a test coverage in lib/internal/dns/promises.
It tests emitting warning when the options types of lookup method are invalid.

ref: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Dec 10, 2021
@kuriyosh
kuriyosh force-pushed the dns-options-test branch from 7aa8603 to 53ad06e Compare December 10, 2021 13:35
@Mesteery Mesteery added the dns Issues and PRs related to the dns subsystem. label Dec 10, 2021
aduh95
aduh95 reviewed Dec 10, 2021
View reviewed changes
Comment thread test/parallel/test-dns-lookup-promises-options-deprecated.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Dec 10, 2021

Copy link
Copy Markdown
Member

Looks like there are some relevant test failures that need to be looked at! :-)
kuriyosh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kuriyosh
test: improve test coverage of dns/promises
1a19763
@kuriyosh
kuriyosh force-pushed the dns-options-test branch 2 times, most recently from 0c67e16 to a197004 Compare December 11, 2021 01:59
kuriyosh
kuriyosh commented Dec 11, 2021
View reviewed changes
Comment thread test/parallel/test-dns-lookup-promises-options-deprecated.js Outdated

@kuriyosh kuriyosh Dec 11, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test only check whether DeprecationWarning is emitted when hints is not a number.
Since the valid string value of hints depends on the OS environment, give an invalid string value here and assert the error.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kuriyosh
test: fix dns/promise import & hints type error
53771fb
@kuriyosh
kuriyosh force-pushed the dns-options-test branch from a197004 to 53771fb Compare December 11, 2021 02:06
lpinca
lpinca approved these changes Dec 11, 2021
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41463/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ayase-252
Ayase-252 approved these changes Dec 13, 2021
View reviewed changes
@Ayase-252 Ayase-252 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2021
This was referenced Dec 15, 2021
CI Reliability 2021-12-15 nodejs/reliability#145
Open
CI Reliability 2021-12-16 nodejs/reliability#146
Open
CI Reliability 2021-12-17 nodejs/reliability#147
Open
CI Reliability 2021-12-18 nodejs/reliability#148
Open
CI Reliability 2021-12-19 nodejs/reliability#149
Open
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 19, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 9b903d1 into nodejs:master Dec 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator

Landed in 9b903d1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 20, 2021
CI Reliability 2021-12-20 nodejs/reliability#150
Open
20 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@kuriyosh @targos
test: improve test coverage of dns/promises
f067876 
PR-URL: #41133
Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
@danielleadams danielleadams added the backport-requested-v16.x label Jan 31, 2022
@danielleadams

danielleadams commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

@kuriyosh This caused a failed test when pulling into the v16.x release. Do you mind creating a backport PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kuriyosh

kuriyosh commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@danielleadams
Of course. Please ping me if I have any necessary actions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added dont-land-on-v16.x and removed backport-requested-v16.x labels Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@lpinca lpinca lpinca approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@kuriyosh @jasnell @nodejs-github-bot @danielleadams @lpinca @Ayase-252 @aduh95 @targos @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.