GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: update AUTHORS by nodejs-github-bot · Pull Request #41234 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 19, 2021
Trott
Trott approved these changes Dec 19, 2021
View reviewed changes
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 19, 2021
@github-actions

github-actions Bot commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Dec 19, 2021
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 19, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/41234
✔  Done loading data for nodejs/node/pull/41234
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#41234)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta, fast-track
Commits    1
 - meta: update AUTHORS
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/41234
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41234
Reviewed-By: Rich Trott 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Dec 2021 00:16:21 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41234#pullrequestreview-835820122
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41234#pullrequestreview-835874794
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1598856323
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 19, 2021
@nodejs-github-bot @Trott
meta: update AUTHORS
3ac3704
PR-URL: #41234
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott
Trott force-pushed the actions/authors-update branch from 085c757 to 3ac3704 Compare December 19, 2021 15:38
@Trott

Trott commented Dec 19, 2021

Copy link
Copy Markdown
Member

Landed in 3ac3704

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott
Trott merged commit 3ac3704 into master Dec 19, 2021
@Trott
Trott deleted the actions/authors-update branch December 19, 2021 15:38
targos pushed a commit that referenced this pull request Jan 14, 2022
@nodejs-github-bot @targos
meta: update AUTHORS
edefb41
PR-URL: #41234
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
c58317f
PR-URL: #41234
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
d3444a5
PR-URL: #41234
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nodejs-github-bot @Trott @aduh95 @Bladez1753
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.