GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable by dsanders11 · Pull Request #41235 · nodejs/node

Conversation

@dsanders11

@dsanders11 dsanders11 commented Dec 19, 2021 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Looks like VCBUILD_PYTHON_LOCATION went stale at some point, and isn't read anywhere (searching the repo shows this is the only usage).

Refs: #18621

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to installing Node.js and its installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 19, 2021
@dsanders11
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
e51e093
@dsanders11
dsanders11 force-pushed the patch-1 branch from cc15509 to e51e093 Compare December 19, 2021 05:26
@dsanders11 dsanders11 changed the title build,tools,win: Trim unused VCBUILD_PYTHON_LOCATION variable build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable Dec 19, 2021
RaisinTen
RaisinTen approved these changes Dec 19, 2021
View reviewed changes

@RaisinTen RaisinTen left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses of VCBUILD_PYTHON_LOCATION were removed in #18621, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 19, 2021
jasnell
jasnell approved these changes Dec 19, 2021
View reviewed changes
This was referenced Dec 20, 2021
CI Reliability 2021-12-20 nodejs/reliability#150
Open
CI Reliability 2021-12-21 nodejs/reliability#151
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
richardlau
richardlau approved these changes Dec 21, 2021
View reviewed changes
This was referenced Dec 22, 2021
CI Reliability 2021-12-22 nodejs/reliability#152
Open
CI Reliability 2021-12-23 nodejs/reliability#153
Open
CI Reliability 2021-12-24 nodejs/reliability#154
Open
CI Reliability 2021-12-25 nodejs/reliability#155
Open
CI Reliability 2021-12-26 nodejs/reliability#156
Open
CI Reliability 2021-12-27 nodejs/reliability#157
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 28, 2021
CI Reliability 2021-12-28 nodejs/reliability#158
Open
CI Reliability 2021-12-29 nodejs/reliability#159
Open
CI Reliability 2021-12-30 nodejs/reliability#160
Open
CI Reliability 2021-12-31 nodejs/reliability#161
Open
CI Reliability 2022-01-01 nodejs/reliability#162
Open
CI Reliability 2022-01-02 nodejs/reliability#163
Open
CI Reliability 2022-01-03 nodejs/reliability#164
Open
@github-actions github-actions Bot mentioned this pull request Jan 4, 2022
CI Reliability 2022-01-04 nodejs/reliability#165
Open
25 tasks
@github-actions github-actions Bot mentioned this pull request Jan 5, 2022
CI Reliability 2022-01-05 nodejs/reliability#166
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41757/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 79b21ee into nodejs:master Jan 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 79b21ee
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dsanders11
dsanders11 deleted the patch-1 branch January 6, 2022 22:24
targos pushed a commit that referenced this pull request Jan 14, 2022
@dsanders11 @targos
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
2233f31 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@dsanders11 @danielleadams
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
fc38d15 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. install Issues and PRs related to installing Node.js and its installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@dsanders11 @nodejs-github-bot @jasnell @richardlau @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.