GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: enable prefer-object-has-own lint rule by Trott · Pull Request #41245 · nodejs/node

Conversation

@Trott

@Trott Trott commented Dec 19, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

First commit is from #41229.

Second commit enables the lint rule. Ref: https://eslint.org/docs/rules/prefer-object-has-own

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. dont-land-on-v12.x labels Dec 19, 2021
@github-actions

github-actions Bot commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
bricss and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Dec 19, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 19, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 19, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell
jasnell approved these changes Dec 19, 2021
View reviewed changes
aduh95
aduh95 approved these changes Dec 19, 2021
View reviewed changes
tniessen
tniessen approved these changes Dec 19, 2021
View reviewed changes
lpinca
lpinca approved these changes Dec 19, 2021
View reviewed changes
@Trott
tools: enable prefer-object-has-own lint rule
b0c4620
@Trott
Trott force-pushed the prefer-has-own branch from 3ba9f42 to b0c4620 Compare December 20, 2021 04:52
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 20, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 20, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 approved these changes Dec 20, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41554/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 20, 2021
BridgeAR
BridgeAR approved these changes Dec 20, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Dec 20, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41559/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 21, 2021
CI Reliability 2021-12-21 nodejs/reliability#151
Open
22 tasks
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Dec 21, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 21, 2021
@nodejs-github-bot
nodejs-github-bot merged commit 340998e into nodejs:master Dec 21, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Landed in 340998e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the prefer-has-own branch December 21, 2021 18:17
This was referenced Dec 22, 2021
CI Reliability 2021-12-22 nodejs/reliability#152
Open
CI Reliability 2021-12-23 nodejs/reliability#153
Open
CI Reliability 2021-12-24 nodejs/reliability#154
Open
CI Reliability 2021-12-25 nodejs/reliability#155
Open
CI Reliability 2021-12-26 nodejs/reliability#156
Open
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: enable prefer-object-has-own lint rule
dae2e5f 
PR-URL: #41245
Refs: https://eslint.org/docs/rules/prefer-object-has-own
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
@danielleadams danielleadams added the backport-blocked-v16.x label Jan 31, 2022
@danielleadams danielleadams removed the backport-blocked-v16.x label Feb 1, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: enable prefer-object-has-own lint rule
49dc1f2 
PR-URL: #41245
Refs: https://eslint.org/docs/rules/prefer-object-has-own
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig @tniessen @BridgeAR @aduh95 @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.