GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix sync comment in observer example by erj826 · Pull Request #41262 · nodejs/node

Conversation

@erj826

@erj826 erj826 commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Updates doc comment here since the PerformanceObserver callback is always called asynchronously.

Refs: #41259

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Eric Jacobson
doc: fix sync comment in observer snippet
0b7c9a1
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. labels Dec 21, 2021
lpinca
lpinca approved these changes Dec 21, 2021
View reviewed changes
jasnell
jasnell approved these changes Dec 21, 2021
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 21, 2021
@github-actions

github-actions Bot commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
lpinca, erj826, VoltrexKeyva, and HarshithaKP reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes Dec 22, 2021
View reviewed changes
HarshithaKP
HarshithaKP approved these changes Dec 22, 2021
View reviewed changes
@erj826

erj826 commented Dec 27, 2021

Copy link
Copy Markdown
Contributor Author

Anything else I need to do to get this across the finish line?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 27, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 27, 2021
@nodejs-github-bot
nodejs-github-bot merged commit d34fcb6 into nodejs:master Dec 27, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2021

Copy link
Copy Markdown
Collaborator

Landed in d34fcb6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 14, 2022
@erj826 @targos
doc: fix sync comment in observer snippet
5cfc547 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@erj826 @danielleadams
doc: fix sync comment in observer snippet
cc4df85 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@erj826 @danielleadams
doc: fix sync comment in observer snippet
1c0c140 
PR-URL: #41262
Refs: #41259
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erj826 @nodejs-github-bot @jasnell @lpinca @HarshithaKP @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.