GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: start build on z/OS by alexcfyung · Pull Request #41273 · nodejs/node

Conversation

@alexcfyung

@alexcfyung alexcfyung commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Just with this commit node.js won't build on z/OS as it just start the build.
This will be the first pr to upstream z/OS changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alexcfyung @gabylb @zsw007
build: start build on z/OS
ad18229 
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Co-authored-by: Gaby Baghdadi <[email protected]>
Co-authored-by: Wayne Zhang <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Dec 21, 2021
richardlau
richardlau approved these changes Dec 21, 2021
View reviewed changes
@richardlau

richardlau commented Dec 21, 2021

Copy link
Copy Markdown
Member

cc @nodejs/build-files @nodejs/platform-zos
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Dec 21, 2021
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ryzokuken
ryzokuken approved these changes Jan 6, 2022
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 6, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41775/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit f6e5050 into nodejs:master Jan 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in f6e5050
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 14, 2022
@alexcfyung @targos
build: start build on z/OS
b0f0ad1 
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Co-authored-by: Gaby Baghdadi <[email protected]>
Co-authored-by: Wayne Zhang <[email protected]>

PR-URL: #41273
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@alexcfyung @danielleadams
build: start build on z/OS
c49a651 
Update configure.py, Makefile, and common.gypi to get the
build started on z/OS.

Co-authored-by: Gaby Baghdadi <[email protected]>
Co-authored-by: Wayne Zhang <[email protected]>

PR-URL: #41273
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+2 more reviewers
@mhdawson mhdawson mhdawson approved these changes
@ryzokuken ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@alexcfyung @nodejs-github-bot @richardlau @mhdawson @ryzokuken
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.