GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: enable jsdoc/check-param-names lint rule by Trott · Pull Request #41311 · nodejs/node

Conversation

@Trott

@Trott Trott commented Dec 24, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 24, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Dec 24, 2021
@github-actions

github-actions Bot commented Dec 24, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
aduh95 and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Dec 25, 2021
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Dec 25, 2021
@Trott Trott added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Dec 25, 2021
@aduh95 aduh95 removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 27, 2021
lpinca
lpinca approved these changes Dec 28, 2021
View reviewed changes
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 28, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 28, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 28, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41311
✔  Done loading data for nodejs/node/pull/41311
----------------------------------- PR info ------------------------------------
Title      tools: enable jsdoc/check-param-names lint rule (#41311)
Author     Rich Trott  (@Trott)
Branch     Trott:jsdoc-check-param-names -> nodejs:master
Labels     tools, author ready, commit-queue-rebase
Commits    2
 - events: clarify JSDoc entries
 - tools: enable jsdoc/check-param-names lint rule
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41311
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41311
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 24 Dec 2021 15:30:28 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41311#pullrequestreview-839997812
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41311#pullrequestreview-841065507
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1631805998
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 28, 2021
@Trott Trott removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 28, 2021
Trott added 2 commits December 28, 2021 13:16
@Trott
events: clarify JSDoc entries
43371dd 
Split the JSDoc entries into separate blocks.

This is in preparation for enabling jsdoc/check-param-names lint rule.

PR-URL: nodejs#41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
tools: enable jsdoc/check-param-names lint rule
f81c627 
PR-URL: nodejs#41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the jsdoc-check-param-names branch from c618d91 to f81c627 Compare December 28, 2021 21:17
@Trott

Trott commented Dec 28, 2021

Copy link
Copy Markdown
Member Author

Landed in 5ed7066...f81c627
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit f81c627 into nodejs:master Dec 28, 2021
@Trott
Trott deleted the jsdoc-check-param-names branch December 28, 2021 21:19
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
events: clarify JSDoc entries
9fe304b 
Split the JSDoc entries into separate blocks.

This is in preparation for enabling jsdoc/check-param-names lint rule.

PR-URL: #41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: enable jsdoc/check-param-names lint rule
0ca7cda 
PR-URL: #41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
@danielleadams danielleadams added the backport-blocked-v16.x label Jan 31, 2022
@danielleadams danielleadams removed the backport-blocked-v16.x label Feb 1, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
events: clarify JSDoc entries
1280e19 
Split the JSDoc entries into separate blocks.

This is in preparation for enabling jsdoc/check-param-names lint rule.

PR-URL: #41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: enable jsdoc/check-param-names lint rule
f31a3a2 
PR-URL: #41311
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @lpinca @aduh95 @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.