GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — benchmark: fix benchmark/run.js handling of --set by Trott · Pull Request #41334 · nodejs/node Conversation
Member
run.js does not work with --set as it tries to include it as
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsrun.js does not work with --set as it tries to include it as options to `fork()` rather than as part of argv for `fork()`. This doesn't throw an error because of a quirk in `fork()` that silently accepts arrays for options objects. This will be changing in Node.js 18.x.
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
aduh95
approved these changes
lpinca
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
targos
pushed a commit
that referenced
this pull request
run.js does not work with --set as it tries to include it as options to `fork()` rather than as part of argv for `fork()`. This doesn't throw an error because of a quirk in `fork()` that silently accepts arrays for options objects. This will be changing in Node.js 18.x. PR-URL: #41334 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
run.js does not work with --set as it tries to include it as options to `fork()` rather than as part of argv for `fork()`. This doesn't throw an error because of a quirk in `fork()` that silently accepts arrays for options objects. This will be changing in Node.js 18.x. PR-URL: #41334 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
run.js does not work with --set as it tries to include it as options to `fork()` rather than as part of argv for `fork()`. This doesn't throw an error because of a quirk in `fork()` that silently accepts arrays for options objects. This will be changing in Node.js 18.x. PR-URL: #41334 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
benchmark
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 4 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |