GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix example description for worker_threads by krutoo · Pull Request #41341 · nodejs/node

Conversation

@krutoo

@krutoo krutoo commented Dec 27, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@krutoo
doc: fix example description for worker_threads
51f3c1f
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API. labels Dec 27, 2021
cjihrig
cjihrig approved these changes Dec 27, 2021
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You don't need to, but would you mind removing "actual" from the end of the line as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
krutoo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@krutoo
doc: fix linter issue in worker_threads
8fad3d9
@krutoo

krutoo commented Dec 27, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@cjihrig Sure, like this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Dec 27, 2021
View reviewed changes
Comment thread doc/api/worker_threads.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Dec 27, 2021
@krutoo @aduh95
doc: sentence fix in worker_threads
23ed378 
Co-authored-by: Antoine du Hamel <[email protected]>
lpinca
lpinca approved these changes Dec 27, 2021
View reviewed changes
tniessen
tniessen approved these changes Dec 27, 2021
View reviewed changes
fhinkel
fhinkel approved these changes Dec 28, 2021
View reviewed changes
HarshithaKP
HarshithaKP approved these changes Dec 28, 2021
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Dec 28, 2021
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 31, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 31, 2021
@nodejs-github-bot
nodejs-github-bot merged commit dae64a9 into nodejs:master Dec 31, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 31, 2021

Copy link
Copy Markdown
Collaborator

Landed in dae64a9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 14, 2022
@krutoo @targos
doc: fix example description for worker_threads
c267bb2 
PR-URL: #41341
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@krutoo @danielleadams
doc: fix example description for worker_threads
19b4d48 
PR-URL: #41341
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@krutoo @danielleadams
doc: fix example description for worker_threads
41cfc32 
PR-URL: #41341
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+2 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@krutoo @nodejs-github-bot @fhinkel @lpinca @cjihrig @tniessen @aduh95 @HarshithaKP @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.