GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: remove Python 2 workaround by Trott · Pull Request #41357 · nodejs/node

Conversation

@Trott

@Trott Trott commented Dec 30, 2021

Copy link
Copy Markdown
Member

Remove workaround for Python 2.

I confirmed that V8 build still works by running ./configure.py && make v8.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott
build: remove Python 2 workaround
2fdd5e2 
Remove workaround for Python 2.

I confirmed that V8 build still works by running `./configure.py &&
make v8`.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Dec 30, 2021
@Trott

Trott commented Dec 30, 2021

Copy link
Copy Markdown
Member Author

/ping @nodejs/v8-update in case this is premature
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen approved these changes Dec 30, 2021
View reviewed changes
@targos

targos commented Dec 30, 2021

Copy link
Copy Markdown
Member

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4449/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Dec 30, 2021

Copy link
Copy Markdown
Member Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4449/

V8 CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 30, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 30, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41689/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Dec 30, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41693/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 30, 2021
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41694/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Dec 31, 2021
CI Reliability 2021-12-31 nodejs/reliability#161
Open
26 tasks
gengjiawen
gengjiawen approved these changes Dec 31, 2021
View reviewed changes
Lxxyx
Lxxyx approved these changes Dec 31, 2021
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jan 1, 2022
CI Reliability 2022-01-01 nodejs/reliability#162
Open
24 tasks
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 5999731 into nodejs:master Jan 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 1, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5999731
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the py2-conf branch January 1, 2022 16:46
This was referenced Jan 2, 2022
CI Reliability 2022-01-02 nodejs/reliability#163
Open
CI Reliability 2022-01-03 nodejs/reliability#164
Open
CI Reliability 2022-01-04 nodejs/reliability#165
Open
CI Reliability 2022-01-05 nodejs/reliability#166
Open
CI Reliability 2022-01-06 nodejs/reliability#167
Open
CI Reliability 2022-01-07 nodejs/reliability#168
Open
CI Reliability 2022-01-08 nodejs/reliability#169
Open
@github-actions github-actions Bot mentioned this pull request Jan 9, 2022
CI Reliability 2022-01-09 nodejs/reliability#170
Open
18 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
build: remove Python 2 workaround
afe1e00 
Remove workaround for Python 2.

I confirmed that V8 build still works by running `./configure.py &&
make v8`.

PR-URL: #41357
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
@richardlau richardlau added dont-land-on-v12.x labels Jan 18, 2022
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
build: remove Python 2 workaround
ec578f1 
Remove workaround for Python 2.

I confirmed that V8 build still works by running `./configure.py &&
make v8`.

PR-URL: #41357
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: remove Python 2 workaround
ff48705 
Remove workaround for Python 2.

I confirmed that V8 build still works by running `./configure.py &&
make v8`.

PR-URL: #41357
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Trott @targos @nodejs-github-bot @lpinca @tniessen @gengjiawen @Lxxyx @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.