GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix argv bug in find-inactive-tsc.mjs by Trott · Pull Request #41394 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 4, 2022

Copy link
Copy Markdown
Member

The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Trott
tools: fix argv bug in find-inactive-tsc.mjs
6e5ce35
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 4, 2022
targos
targos approved these changes Jan 4, 2022
View reviewed changes
cjihrig
cjihrig approved these changes Jan 4, 2022
View reviewed changes
richardlau
richardlau approved these changes Jan 4, 2022
View reviewed changes
lpinca
lpinca approved these changes Jan 4, 2022
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 4, 2022
antsmartian
antsmartian approved these changes Jan 5, 2022
View reviewed changes
tniessen
tniessen approved these changes Jan 5, 2022
View reviewed changes
Lxxyx
Lxxyx approved these changes Jan 5, 2022
View reviewed changes
apapirovski
apapirovski approved these changes Jan 6, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 7, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 95e1f92 into nodejs:master Jan 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 95e1f92

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott
Trott deleted the plus-argv-2 branch January 7, 2022 02:02
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: fix argv bug in find-inactive-tsc.mjs
583f8d9
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

PR-URL: #41394
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: fix argv bug in find-inactive-tsc.mjs
2bc381e
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

PR-URL: #41394
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
+3 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@antsmartian antsmartian antsmartian approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@Trott @nodejs-github-bot @apapirovski @antsmartian @lpinca @targos @cjihrig @tniessen @richardlau @Lxxyx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.