GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark test-performance-eventloopdelay flaky by mhdawson · Pull Request #41409 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Jan 5, 2022

Copy link
Copy Markdown
Member

Refs: #41286

This is one of the remaining high indicende failures
in the CI. Mark as flaky while it is investigated.

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
test: mark test-performance-eventloopdelay flaky
f502956 
Refs: nodejs#41286

This is one of the remaining high indicende failures
in the CI. Mark as flaky while it is investigated.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jan 5, 2022
@mhdawson

mhdawson commented Jan 5, 2022

Copy link
Copy Markdown
Member Author

This and the windows recursive remove dir seemed to be the cause of many of the recent failures which did not look like build/machine type failures.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 5, 2022
View reviewed changes
richardlau
richardlau approved these changes Jan 5, 2022
View reviewed changes
@richardlau

richardlau commented Jan 5, 2022

Copy link
Copy Markdown
Member

FWIW this may have been introduced by 23637e9 (in case anyone is able to make more progress). FYI @jasnell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jan 5, 2022
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41766/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Jan 5, 2022

Copy link
Copy Markdown
Member Author

I'd like to suggest a fast track on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 5, 2022
@github-actions

github-actions Bot commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.
richardlau and Trott reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41767/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 6, 2022
CI Reliability 2022-01-06 nodejs/reliability#167
Open
19 tasks
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0b4e9ae into nodejs:master Jan 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 0b4e9ae
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 7, 2022
CI Reliability 2022-01-07 nodejs/reliability#168
Open
CI Reliability 2022-01-08 nodejs/reliability#169
Open
CI Reliability 2022-01-09 nodejs/reliability#170
Open
CI Reliability 2022-01-12 nodejs/reliability#171
Open
CI Reliability 2022-01-13 nodejs/reliability#172
Open
@github-actions github-actions Bot mentioned this pull request Jan 14, 2022
CI Reliability 2022-01-14 nodejs/reliability#173
Open
22 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson @targos
test: mark test-performance-eventloopdelay flaky
3e2154d 
Refs: #41286

This is one of the remaining high indicende failures
in the CI. Mark as flaky while it is investigated.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41409
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
test: mark test-performance-eventloopdelay flaky
3bd8e92 
Refs: #41286

This is one of the remaining high indicende failures
in the CI. Mark as flaky while it is investigated.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41409
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhdawson @richardlau @nodejs-github-bot @Trott @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.