GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add @RaisinTen to the TSC by mhdawson · Pull Request #41419 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member

Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jan 6, 2022
@mhdawson

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

I'll land once I get through the onboarding steps (assuming there are enough approvals/waiting time is complete by then)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jan 6, 2022
View reviewed changes
aduh95
aduh95 approved these changes Jan 6, 2022
View reviewed changes
@mhdawson

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

Believe we can fast track this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 6, 2022
@github-actions

github-actions Bot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.
apapirovski, bnb, gireeshpunathil, and tniessen reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
apapirovski
apapirovski approved these changes Jan 6, 2022
View reviewed changes

@apapirovski apapirovski left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have the vote directory in nodejs/tsc, should we create that PR first and then reference it here?

Although I guess the json is mostly for bookkeeping, since the vote happens in the issue thread... which makes me think, should our votes just be PRs against the TSC repo? Would simplify the automation too.

Edit: I suppose upon further reflection, a decent % of our votes are not binary which would make the PR format not particularly helpful.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnb bnb changed the title doc: add @RaisenTen to the TSC doc: add @RaisinTen to the TSC Jan 6, 2022
@bnb

bnb commented Jan 6, 2022

Copy link
Copy Markdown
Member

(updated the title to match the other PR, there was an error in the name)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Jan 6, 2022

Copy link
Copy Markdown
Member

(updated the title to match the other PR, there was an error in the name)

@mhdawson The commit title would need to be updated as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen approved these changes Jan 6, 2022
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@mhdawson
doc: add @RaisinTen to the TSC
66b1054 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
mhdawson force-pushed the add-tsc branch from 3c90ad0 to 66b1054 Compare January 6, 2022 21:17
@mhdawson

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

@richardlau fixed
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Jan 7, 2022
View reviewed changes
Trott
Trott approved these changes Jan 7, 2022
View reviewed changes
bnb
bnb approved these changes Jan 7, 2022
View reviewed changes
BethGriggs
BethGriggs approved these changes Jan 7, 2022
View reviewed changes
@aduh95 aduh95 mentioned this pull request Jan 7, 2022
Nominating Darshan Sen (RaisinTen) to be a TSC member nodejs/TSC#1141
Closed
mmarchini
mmarchini approved these changes Jan 7, 2022
View reviewed changes
@mhdawson

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

Ok, added to all required groups, created PRs to add to emails.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson added a commit that referenced this pull request Jan 7, 2022
@mhdawson
doc: add @RaisinTen to the TSC
46f4d5e 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41419
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
@mhdawson

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

Landed in 46f4d5e
RaisinTen reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Jan 7, 2022
@mhdawson

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

@RaisinTen Welcome !
RaisinTen reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 14, 2022
@mhdawson @targos
doc: add @RaisinTen to the TSC
d3111bf 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41419
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
doc: add @RaisinTen to the TSC
66b90f9 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41419
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes
@Trott Trott Trott approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@mhdawson @bnb @richardlau @apapirovski @Trott @tniessen @mmarchini @gireeshpunathil @BethGriggs @aduh95 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.