GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: fix error-path function call by Trott · Pull Request #41433 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 7, 2022

Copy link
Copy Markdown
Member

The onFinish() function takes a single argument. The two extra
arguments passed here are already in the function scope, and may result
in the error being mishandled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
stream: fix error-path function call
241292f 
The `onFinish()` function takes a single argument. The two extra
arguments passed here are already in the function scope, and may result
in the error being mishandled.
@nodejs-github-bot

nodejs-github-bot commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 7, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 7, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
ronag
ronag approved these changes Jan 7, 2022
View reviewed changes
lpinca
lpinca approved these changes Jan 7, 2022
View reviewed changes
apapirovski
apapirovski approved these changes Jan 7, 2022
View reviewed changes

@apapirovski apapirovski left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test so that this isn't so easy to break in the future? Looks like the error behavior has been broken for 6 months... Or at least open an issue ticket to add a test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
mcollina
mcollina approved these changes Jan 7, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Jan 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41784/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jan 8, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Jan 8, 2022
View reviewed changes
@VoltrexKeyva VoltrexKeyva added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Jan 8, 2022
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 11, 2022
@Trott

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Should we add a test so that this isn't so easy to break in the future? Looks like the error behavior has been broken for 6 months... Or at least open an issue ticket to add a test.

Based on https://coverage.nodejs.org/coverage-f17b73cebd82babe/lib/internal/streams/writable.js.html#L715, it appears that the line of code in question here is not tested at all. 😳
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8c3637c into nodejs:master Jan 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8c3637c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the stream-error branch January 11, 2022 02:55
Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2022
@Trott
test: increase coverage for stream writable
9044389 
Refs: nodejs#41433 (comment)
@Trott Trott mentioned this pull request Jan 12, 2022
test: increase coverage for stream writable #41486
Merged
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
stream: fix error-path function call
b08138f 
The `onFinish()` function takes a single argument. The two extra
arguments passed here are already in the function scope, and may result
in the error being mishandled.

PR-URL: #41433
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
v17.4.0 release proposal #41557
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 17, 2022
@Trott
test: increase coverage for stream writable
8de858b 
Refs: #41433 (comment)

PR-URL: #41486
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@Trott @BethGriggs
test: increase coverage for stream writable
c0aec67 
Refs: #41433 (comment)

PR-URL: #41486
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
stream: fix error-path function call
ae30b39 
The `onFinish()` function takes a single argument. The two extra
arguments passed here are already in the function scope, and may result
in the error being mishandled.

PR-URL: #41433
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@ronag ronag ronag approved these changes
+2 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Trott @nodejs-github-bot @apapirovski @mcollina @benjamingr @lpinca @ronag @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.