GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — tools: fix small not-quite-a-bug in find-inactive-tsc.mjs by Trott · Pull Request #41469 · nodejs/node Conversation
Member
The current code attempts to count votes from people who were not
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe current code attempts to count votes from people who were not members at the start of the 3 month period, resulting in `NaN` being tallied for their votes.
gireeshpunathil
approved these changes
richardlau
approved these changes
tniessen
approved these changes
bnb
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
targos
pushed a commit
that referenced
this pull request
The current code attempts to count votes from people who were not members at the start of the 3 month period, resulting in `NaN` being tallied for their votes. PR-URL: #41469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
The current code attempts to count votes from people who were not members at the start of the 3 month period, resulting in `NaN` being tallied for their votes. PR-URL: #41469 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
author ready
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 6 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |