GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix npm version detection by targos · Pull Request #41575 · nodejs/node

Conversation

@targos

@targos targos commented Jan 18, 2022

Copy link
Copy Markdown
Member

Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
build: fix npm version detection
a8f0fee 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850
@targos targos added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Jan 18, 2022
@github-actions

github-actions Bot commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
aduh95, panva, evanlucas, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request Jan 18, 2022
macOS pkg release build failures nodejs/build#2850
Closed
@targos

targos commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

Requesting to fast-track because this is blocking today's 17.x release.
vdeturckheim, panva, richardlau, and gengjiawen reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jan 18, 2022
View reviewed changes
@targos

targos commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

/cc @nodejs/collaborators I have very little time left to do the release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vdeturckheim
vdeturckheim approved these changes Jan 18, 2022
View reviewed changes
panva
panva approved these changes Jan 18, 2022
View reviewed changes
@targos targos added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 18, 2022
evanlucas
evanlucas approved these changes Jan 18, 2022
View reviewed changes
richardlau
richardlau approved these changes Jan 18, 2022
View reviewed changes
lpinca
lpinca approved these changes Jan 18, 2022
View reviewed changes
Lxxyx
Lxxyx approved these changes Jan 18, 2022
View reviewed changes
mcollina
mcollina approved these changes Jan 18, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cclauss
cclauss approved these changes Jan 18, 2022
View reviewed changes
tniessen
tniessen approved these changes Jan 18, 2022
View reviewed changes
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jan 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41575
✔  Done loading data for nodejs/node/pull/41575
----------------------------------- PR info ------------------------------------
Title      build: fix npm version detection (#41575)
Author     Michaël Zasso  (@targos)
Branch     targos:fix-pkg -> nodejs:master
Labels     build, fast-track, author ready, needs-ci
Commits    1
 - build: fix npm version detection
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/41575
Fixes: https://github.com/nodejs/build/issues/2850
Reviewed-By: Antoine du Hamel 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Filip Skokan 
Reviewed-By: Evan Lucas 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Zijian Liu 
Reviewed-By: Matteo Collina 
Reviewed-By: Christian Clauss 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41575
Fixes: https://github.com/nodejs/build/issues/2850
Reviewed-By: Antoine du Hamel 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Filip Skokan 
Reviewed-By: Evan Lucas 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Zijian Liu 
Reviewed-By: Matteo Collina 
Reviewed-By: Christian Clauss 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Jan 2022 10:39:35 GMT
   ✔  Approvals: 10
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855244531
   ✔  - Vladimir de Turckheim (@vdeturckheim): https://github.com/nodejs/node/pull/41575#pullrequestreview-855256162
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/41575#pullrequestreview-855257311
   ✔  - Evan Lucas (@evanlucas): https://github.com/nodejs/node/pull/41575#pullrequestreview-855285931
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855297007
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41575#pullrequestreview-855300576
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/41575#pullrequestreview-855303507
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855307827
   ✔  - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/41575#pullrequestreview-855343615
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855377040
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1712846536
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Landed in 331b906
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Jan 18, 2022
targos added a commit that referenced this pull request Jan 18, 2022
@targos
build: fix npm version detection
331b906 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos added a commit that referenced this pull request Jan 18, 2022
@targos
build: fix npm version detection
4958c80 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos
targos deleted the fix-pkg branch January 18, 2022 13:24
@targos targos removed author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jan 18, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@targos @danielleadams
build: fix npm version detection
5c1dc5f 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
v16.14.0 proposal #41804
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@cclauss cclauss cclauss approved these changes
@richardlau richardlau richardlau approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@evanlucas evanlucas evanlucas approved these changes
@vdeturckheim vdeturckheim vdeturckheim approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macOS pkg release build failures

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@targos @nodejs-github-bot @mcollina @panva @evanlucas @lpinca @tniessen @cclauss @richardlau @vdeturckheim @Lxxyx @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.