GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix timeout of test-heap-prof.js in riscv devices by ArchFeh · Pull Request #42674 · nodejs/node

Conversation

@ArchFeh

@ArchFeh ArchFeh commented Apr 9, 2022

Copy link
Copy Markdown

In riscv hardware test-heap-prof.js caused timeout in test because of weak performance. So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
techiedesu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Apr 9, 2022
@ArchFeh
ArchFeh force-pushed the riscv branch from 2f8071e to adbdf49 Compare April 9, 2022 16:18
ArchFeh
test: fix timeout of test-heap-prof.js in riscv devices
1944947 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: nodejs#40152
@ArchFeh
ArchFeh force-pushed the riscv branch from adbdf49 to 1944947 Compare April 9, 2022 16:21
jasnell
jasnell approved these changes Apr 13, 2022
View reviewed changes
@olof-nord

olof-nord commented Sep 26, 2022

Copy link
Copy Markdown

Hello @ArchFeh, with this PR now approved, are there any open tasks or is it ready to be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ArchFeh

ArchFeh commented Sep 27, 2022

Copy link
Copy Markdown
Author

Hello @ArchFeh, with this PR now approved, are there any open tasks or is it ready to be merged?

Hi! I think it is ready to be merged. Thanks!
olof-nord reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@olof-nord

olof-nord commented Sep 27, 2022

Copy link
Copy Markdown

Hello @jasnell! With this PR approved and ready, what are the outstanding steps required for it to be merged?
I am asking, as there has been no update since a few months.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 2, 2022

Copy link
Copy Markdown
Member

oy, I would have expected this to have landed already :-/ ... I'll start a CI run again just to confirm but this should be able to land now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/42674
✔  Done loading data for nodejs/node/pull/42674
----------------------------------- PR info ------------------------------------
Title      test: fix timeout of test-heap-prof.js in riscv devices (#42674)
Author     Yu Gu  (@ArchFeh, first-time contributor)
Branch     ArchFeh:riscv -> nodejs:main
Labels     build, test, tools, python, needs-ci
Commits    1
 - test: fix timeout of test-heap-prof.js in riscv devices
Committers 1
 - ArchFeh 
PR-URL: https://github.com/nodejs/node/pull/42674
Fixes: https://github.com/nodejs/node/issues/40152
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42674
Fixes: https://github.com/nodejs/node/issues/40152
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 09 Apr 2022 16:14:48 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42674#pullrequestreview-941119183
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3168192279
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46987/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47003/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 4, 2022
CI Reliability 2022-10-04 nodejs/reliability#394
Open
CI Reliability 2022-10-05 nodejs/reliability#395
Open
CI Reliability 2022-10-06 nodejs/reliability#396
Open
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 28, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47522/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 29, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 186745b into nodejs:main Oct 29, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2022

Copy link
Copy Markdown
Collaborator

Landed in 186745b
olof-nord reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Yu Gu @RafaelGSS
test: fix timeout of test-heap-prof.js in riscv devices
20b0c1a 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Yu Gu @RafaelGSS
test: fix timeout of test-heap-prof.js in riscv devices
069747b 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <[email protected]>
@olof-nord olof-nord mentioned this pull request Nov 27, 2022
RISC-V to Experimental tier nodejs/build#2876
Closed
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Yu Gu @danielleadams
test: fix timeout of test-heap-prof.js in riscv devices
59e09f7 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Yu Gu @danielleadams
test: fix timeout of test-heap-prof.js in riscv devices
fe91ac1 
In riscv hardware test-heap-prof.js caused timeout in test.
Because of weak performance.
So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.

Fixes: #40152
PR-URL: #42674
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failures in 16.9.1 on Linux/rv64

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ArchFeh @olof-nord @jasnell @nodejs-github-bot @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.