GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v5.3.0 Release Proposal (Stable) by Fishrock123 · Pull Request #4281 · nodejs/node

Conversation

@Fishrock123

@Fishrock123 Fishrock123 commented Dec 14, 2015

Copy link
Copy Markdown
Contributor

The usual weekly-ish.

I think this would be a minor but I didn't check too in detail.

I'll be out tomorrow, so If someone else from @nodejs/release (@cjihrig maybe?) wants to take this up, I've created the PR base as https://github.com/nodejs/node/tree/propose-v5.3.0

Edited from here down by @cjihrig

  • [6ca5ea3860] - 2015-12-09, Version 5.2.0 (Stable) (Rod Vagg) #4181
  • [da5cdc2207] - assert: accommodate ES6 classes that extend Error (Rich Trott) #4166
  • [67e181986a] - (SEMVER-MINOR) buffer: add includes() for parity with TypedArray (Alexander Martin) #3567
  • [84dea1bd0c] - configure: fix arm vfpv2 (Jörg Krause) #4203
  • [a7f5dfd14c] - configure: use __ARM_ARCH to determine arm version (João Reis) #4123
  • [0e3912be0b] - configure: respect CC_host in host arch detection (João Reis) #4117
  • [69b94ec55c] - deps: upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) #4276
  • [a8854e5b59] - doc: document the cache parameter for fs.realpathSync (Jackson Tian) #4285
  • [9e1b7aa874] - doc: document backlog for server.listen() variants (Jan Schär) #4025
  • [435d571f22] - doc: update AUTHORS list (Rod Vagg) #4183
  • [3b3061365a] - doc: update irc channels: #node.js and #node-dev (Nelson Pecora) #2743
  • [9538fd02e5] - doc: clarify error events in HTTP module documentation (Lenny Markus) #4275
  • [c6efd535e4] - doc: fix improper http.get sample code (Hideki Yamamura) #4263
  • [498c9adb08] - doc: add CTC meeting minutes 2015-10-28 (Rod Vagg) #3661
  • [671347cf13] - doc: fixup socket.remoteAddress (Arthur Gautier) #4198
  • [f050cab3d8] - doc: copyedit console doc (Rich Trott) #4225
  • [1a21a5368b] - doc: move description of 'equals' method to right place (janriemer) #4227
  • [9a9c5259bf] - doc: Fixing broken links to the v8 wiki (Tom Gallacher) #4241
  • [37ed05b8c1] - doc: copyedit child_process doc (Rich Trott) #4188
  • [e47ae5808b] - doc: copyedit buffer doc (Rich Trott) #4187
  • [70fb06a90b] - doc: clarify assert.fail doc (Rich Trott) #4186
  • [e3187cc81e] - doc: copyedit addons doc (Rich Trott) #4185
  • [931ab967ff] - doc: add calvinmetcalf to collaborators (Calvin Metcalf) #4218
  • [01ce23148b] - doc: add mcollina to collaborators (Matteo Collina) #4220
  • [bd8753aabf] - doc: add rmg to collaborators (Ryan Graham) #4219
  • [73a9a6fc92] - doc: harmonize description of ca argument (Ben Noordhuis) #4213
  • [dfc8bedbc5] - doc: change references from node to Node.js (Roman Klauke) #4177
  • [7a518788e9] - doc, test: symbols as event names (Bryan English) #4151
  • [425a3545d2] - (SEMVER-MINOR) domains: fix handling of uncaught exceptions (Julien Gilli) #3654
  • [acef181fde] - (SEMVER-MINOR) https: support disabling session caching (Fedor Indutny) #4252
  • [2a60e2ad71] - module,src: do not wrap modules with -1 lineOffset (cjihrig) #4298
  • [d3c498b1b7] - node: remove unused variables in AppendExceptionLine (Yazhong Liu) #4264
  • [aad6b9f0eb] - repl: display error message when loading directory (Prince J Wesley) #4170
  • [213ede6cee] - repl: fix require('3rdparty') regression (Ben Noordhuis) #4215
  • [f176b31e74] - src: remove __builtin_bswap16 call (Ben Noordhuis) #4290
  • [ce2471673f] - src: remove unused BITS_PER_LONG macro (Ben Noordhuis) #4290
  • [b799a74709] - src: fix line numbers on core errors (cjihrig) #4254
  • [c311b61430] - src: fix deprecation message for ErrnoException (Martin von Gagern) #4269
  • [2859f9ef92] - test: fix debug-port-cluster flakiness (Ben Noordhuis) #4310
  • [cb0b4a6bc0] - test: add test for debugging one line files (cjihrig) #4298
  • [0b9c3a30d6] - test: add test for tls.parseCertString (Evan Lucas) #4283
  • [7598ed6cc0] - test: parallelize test-repl-persistent-history (Jeremiah Senkpiel) #4247
  • [668449ad14] - test: use regular timeout times for ARMv8 (Jeremiah Senkpiel) #4248
  • [23e7703c85] - test: fix http-many-ended-pipelines flakiness (Santiago Gimeno) #4041
  • [3b94991bda] - test: fix tls-inception flakiness (Santiago Gimeno) #4195
  • [86a3bd09b0] - test: fix tls-inception (Santiago Gimeno) #4195
  • [1e89830a11] - test: don't assume openssl s_client supports -ssl3 (Ben Noordhuis) #4204
  • [c5b4f6bc99] - (SEMVER-MINOR) tls: introduce secureContext for tls.connect (Fedor Indutny) #4246
  • [e0bb118a1d] - tls_wrap: inherit from the AsyncWrap first (Fedor Indutny) #4268
  • [d63cceeb10] - tools: add .editorconfig (ronkorving) #2993
  • [4b267df93e] - udp: remove a needless instanceof Buffer check (ronkorving) #4301

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fishrock123
v5.3.0 Release Proposal (edit this)
7c326a5
@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Dec 14, 2015
@cjihrig

cjihrig commented Dec 14, 2015

Copy link
Copy Markdown
Contributor

@Fishrock123 I should be able to work on this tomorrow. Is https://github.com/nodejs/node/blob/master/doc/releases.md still the reference document to use, and is it up to date? It's been a while since I've done a release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

Not seeing #4215 included in this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

Line 30 in the changelog?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

...

facepalm

please ignore me
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg

rvagg commented Dec 15, 2015

Copy link
Copy Markdown
Member

@cjihrig yes, I think that doc is still accurate. Jenkins has been solid (iojs+release job), the flow has been working nicely.

The additional part that's not documented is creating a website post. The easiest way to do that is to wait until you've competed everything else and have promoted the build then run https://github.com/nodejs/nodejs.org/blob/master/scripts/release-post.js to make the post in that repo, it'll use the promoted builds and changelog to build the post and it should be good to go unless you want to make some notes in there. Run npm serve to look at the post before pushing to the repo. I've been doing it as a PR that I immediately merge to master for easier tracking and commenting.

Also, look at the v5.2.0 tag and changelog entry for the current format, we're putting "(Stable)" in there now, just copy all that.

I'll be around in your afternoon if you need any help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins mentioned this pull request Dec 15, 2015
src: remove __builtin_bswap16 call #4290
Merged
@Fishrock123

Fishrock123 commented Dec 15, 2015

Copy link
Copy Markdown
Contributor Author

@cjihrig There are slightly updated notes here: #3254

In specific, can you make sure to not land #3567, even though it is semver-minor? (It needs possible more discussion / cc @trevnorris)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123

Fishrock123 commented Dec 15, 2015

Copy link
Copy Markdown
Contributor Author

Some tips I'm not sure are mentioned:
npm i -g branch-diff
npm i -g changelog-maker

branch-diff v5.x master will show you the commits that can be ported (just make sure there aren't dupes, and don't take semver-majors)

Once you have everything else done, to make the commit list for the blog / make doing the changelog easier:
git checkout v5.x
changelog-maker v5.2.0 --group (then if it looks good) | pbcopy(mac)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig changed the title v5.3.0 Release Proposal (edit this) v5.3.0 Release Proposal (Stable) Dec 15, 2015
cjihrig added a commit that referenced this pull request Dec 15, 2015
@cjihrig
2015-12-15, Version 5.3.0 (Stable)
ea5f3ab 
Notable changes:

* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281
@ofrobots

ofrobots commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

I wonder if it might better to hold off on the release because of #4297
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

@rvagg and @Fishrock123 thanks for the pointers. We should probably work to consolidate the content in releases.md with #3254, and any additional info.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trevnorris

trevnorris commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

@Fishrock123 That's an additive change, so should be fine to land.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rvagg

rvagg commented Dec 16, 2015

Copy link
Copy Markdown
Member

protip for branch-diff to look for changes that can be cherry-picked: branch-diff v5.x master --simple --exclude-label=semver-major,dont-land-on-v5.x, you still have to be careful though cause some things may be missing dont-land-on-v5.x that should have it, like V8 updates.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

I'd like to move on with the release. But I'd like some confirmation that:

  • @Fishrock123 is OK with buffer: Added Buffer#includes() to keep parity with TypedArray. #3567 going in.
  • @ofrobots is OK with the fix for Debuggers & profilers broken on Node.js 5.2 #4297.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123

Fishrock123 commented Dec 16, 2015

Copy link
Copy Markdown
Contributor Author

@cjihrig Seems fine to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig added a commit that referenced this pull request Dec 16, 2015
@cjihrig
2015-12-16, Version 5.3.0 (Stable)
b21110f 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281
@ofrobots

ofrobots commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

@cjihrig The fix for #4297 looks good to me. Thanks for fixing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig added a commit that referenced this pull request Dec 16, 2015
@cjihrig
Working on v5.3.1
17fc5b4 
PR-URL: #4281
cjihrig added a commit that referenced this pull request Dec 16, 2015
@cjihrig
2015-12-16, Version 5.3.0 (Stable)
e5774c9 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281

Conflicts:
	src/node_version.h
@cjihrig

cjihrig commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

Release is done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig closed this Dec 16, 2015
@cjihrig
cjihrig deleted the propose-v5.3.0 branch December 16, 2015 20:29
@Starefossen Starefossen mentioned this pull request Dec 17, 2015
Update Node to 5.3.0 nodejs/docker-node#79
Merged
Starefossen pushed a commit to Starefossen/docker-node that referenced this pull request Dec 17, 2015
Hans Kristian Flaatten
Update Node to 5.3.0
87993b5 
Related: nodejs/node#4281

PR-URL: nodejs#79

Signed-off-by: Hans Kristian Flaatten <[email protected]>
Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Dec 17, 2015
Hans Kristian Flaatten
Update Node.js to v5.3.0
0b5dcd3 
Related: nodejs/node#4281
Related: nodejs/docker-node#79

Signed-off-by: Hans Kristian Flaatten <[email protected]>
@Starefossen Starefossen mentioned this pull request Dec 17, 2015
Update Node.js to v5.3.0 docker-library/official-images#1284
Merged
Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Dec 17, 2015
Hans Kristian Flaatten
Update Node.js to v5.3.0
b1dd0a5 
Related: nodejs/node#4281
Related: nodejs/docker-node#79

Signed-off-by: Hans Kristian Flaatten <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Release 4.2.4 Planning #4321
Closed
pierreozoux pushed a commit to pierreozoux/official-images that referenced this pull request Jan 7, 2016
Hans Kristian Flaatten @pierreozoux
Update Node.js to v5.3.0
a9636f3 
Related: nodejs/node#4281
Related: nodejs/docker-node#79

Signed-off-by: Hans Kristian Flaatten <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig Michael Scovetta
2015-12-16, Version 5.3.0 (Stable)
c74c53a 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) nodejs#3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) nodejs#4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) nodejs#4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) nodejs#4276.

PR-URL: nodejs#4281

Conflicts:
	src/node_version.h
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Hans Kristian Flaatten @rscothern
Update Node.js to v5.3.0
91fa8df 
Related: nodejs/node#4281
Related: nodejs/docker-node#79

Signed-off-by: Hans Kristian Flaatten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Fishrock123 @cjihrig @MylesBorins @rvagg @ofrobots @trevnorris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.