GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update undici to 5.2.0 by nodejs-github-bot · Pull Request #43059 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 11, 2022 •
edited by mcollina
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.2.0.

Fixes #42814

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels May 11, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 11, 2022
@panva

panva commented May 11, 2022

Copy link
Copy Markdown
Member

@nodejs/undici

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ronag
ronag approved these changes May 11, 2022
View reviewed changes
panva
panva approved these changes May 11, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 11, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes May 11, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mcollina mcollina mentioned this pull request May 11, 2022
Make it possible to use Fetch with proxies or other agents #42814
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
VoltrexKeyva
VoltrexKeyva approved these changes May 11, 2022
View reviewed changes
tniessen
tniessen approved these changes May 11, 2022
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 11, 2022
@github-actions

github-actions Bot commented May 11, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

lpinca, mcollina, bricss, gengjiawen, RaisinTen, and VoltrexKeyva reacted with thumbs up emoji
All reactions
  • 👍 6 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes May 11, 2022
View reviewed changes
mcollina
mcollina approved these changes May 11, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mcollina

mcollina commented May 11, 2022

Copy link
Copy Markdown
Member

@targos could you confirm I don't have to do any special bundling on undici for this to work ok?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request May 12, 2022
CI Reliability 2022-05-12 nodejs/reliability#273
Open
30 tasks
@targos

targos commented May 12, 2022

Copy link
Copy Markdown
Member

Bundling is done by the update script and part of this PR: https://github.com/nodejs/node/pull/43059/files#diff-f516ab824a7722da938a4c7c851520d39731ddeb4f7198dff4e932c5d4f8fdf7

mcollina reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request May 12, 2022
CI Reliability 2022-05-12 nodejs/reliability#275
Closed
32 tasks
@mcollina mcollina mentioned this pull request May 12, 2022
v18.2.0 proposal #43036
Merged
RaisinTen
RaisinTen approved these changes May 12, 2022
View reviewed changes
@mcollina

mcollina commented May 12, 2022

Copy link
Copy Markdown
Member

asan build on github keeps failing. What should we do?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented May 12, 2022

Copy link
Copy Markdown
Member

asan build on github keeps failing. What should we do?

I retried 10 times to make it green in #43022 🥲

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen

tniessen commented May 12, 2022

Copy link
Copy Markdown
Member

The ASan job has a really bad track record, but it seems to have gotten even worse. Maybe we should disable it for the time being, unless someone can investigate and fix the failures.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request May 13, 2022
CI Reliability 2022-05-13 nodejs/reliability#276
Open
33 tasks
@mcollina

mcollina commented May 13, 2022

Copy link
Copy Markdown
Member

@nodejs/tsc could I land this anyway even if the ASAN action fails?

ronag and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request May 14, 2022
CI Reliability 2022-05-14 nodejs/reliability#277
Open
3 of 33 tasks
@tniessen

tniessen commented May 14, 2022

Copy link
Copy Markdown
Member

Is there an issue tracking the Test ASan problems? We should probably disable it entirely given its error rate, or fix the underlying problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 15, 2022
@nodejs-github-bot

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44009/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented May 15, 2022

Copy link
Copy Markdown
Member

asan is still failing.

Ugh. Well, now there's a fix, so let's rebase and try yet again.....

There we go!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label May 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 15, 2022
@nodejs-github-bot
nodejs-github-bot merged commit d4cd7bd into master May 15, 2022
@nodejs-github-bot

nodejs-github-bot commented May 15, 2022

Copy link
Copy Markdown
Collaborator Author

Landed in d4cd7bd

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott
Trott deleted the actions/tools-update-undici branch May 15, 2022 13:28
@github-actions github-actions Bot mentioned this pull request May 16, 2022
CI Reliability 2022-05-16 nodejs/reliability#279
Open
25 tasks
BethGriggs pushed a commit that referenced this pull request May 16, 2022
@nodejs-github-bot @BethGriggs
deps: update undici to 5.2.0
d128356
PR-URL: #43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
RafaelGSS added a commit that referenced this pull request May 16, 2022
@RafaelGSS
2022-05-17, Version 18.2.0 (Current)
b7bc76c
OpenSSL

This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18.
See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines.

* deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022
* deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022

Other Notable Changes

* *Revert*_ "deps: add template for generated headers" (Daniel Bevenius) #42978
* deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059
* deps: upgrade npm to 8.9.0 (npm team) #42968
* (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768
* (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812
* doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
* doc: add release key for Juan Arboleda (Juan José) #42961
* (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768
* (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812
* perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725

PR-URL: #43036
RafaelGSS added a commit that referenced this pull request May 16, 2022
@RafaelGSS
2022-05-17, Version 18.2.0 (Current)
1531ef1
Notable changes:

OpenSSL 3.0.3

This update can be treated as a security release as the issues addressed
in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/
for more information on how the May 2022 OpenSSL releases affect other
Node.js release lines.

- deps: update archs files for quictls/openssl-3.0.3+quic
  (RafaelGSS) #43022
- deps: upgrade openssl sources to quictls/openssl-3.0.3
  (RafaelGSS) #43022

Other notable changes:

- _Revert_ "deps: add template for generated headers"
  (Daniel Bevenius) #42978
- deps: update undici to 5.2.0
  (Node.js GitHub Bot) #43059
- deps: upgrade npm to 8.9.0
  (npm team) #42968
- (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
  (LiviaMedeiros) #42768
- (SEMVER-MINOR) http: added connection closing methods
  (Shogun) #42812
- doc: add LiviaMedeiros to collaborators
  (LiviaMedeiros) #43039
- doc: add release key for Juan Arboleda
  (Juan José) #42961
- (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
  (LiviaMedeiros) #42768
- (SEMVER-MINOR) http: added connection closing methods
  (Paolo Insogna) #42812
- (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming
  (RafaelGSS) #42725

PR-URL: #43036
@github-actions github-actions Bot mentioned this pull request May 17, 2022
CI Reliability 2022-05-17 nodejs/reliability#280
Open
23 tasks
RafaelGSS added a commit that referenced this pull request May 17, 2022
@RafaelGSS
2022-05-17, Version 18.2.0 (Current)
2bc1991
Notable changes:

OpenSSL 3.0.3

This update can be treated as a security release as the issues addressed
in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/
for more information on how the May 2022 OpenSSL releases affect other
Node.js release lines.

- deps: update archs files for quictls/openssl-3.0.3+quic
  (RafaelGSS) #43022
- deps: upgrade openssl sources to quictls/openssl-3.0.3
  (RafaelGSS) #43022

Other notable changes:

- _Revert_ "deps: add template for generated headers"
  (Daniel Bevenius) #42978
- deps: update undici to 5.2.0
  (Node.js GitHub Bot) #43059
- deps: upgrade npm to 8.9.0
  (npm team) #42968
- (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
  (LiviaMedeiros) #42768
- (SEMVER-MINOR) http: added connection closing methods
  (Shogun) #42812
- doc: add LiviaMedeiros to collaborators
  (LiviaMedeiros) #43039
- doc: add release key for Juan Arboleda
  (Juan José) #42961
- (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
  (LiviaMedeiros) #42768
- (SEMVER-MINOR) http: added connection closing methods
  (Paolo Insogna) #42812
- (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming
  (RafaelGSS) #42725

PR-URL: #43036
This was referenced May 18, 2022
CI Reliability 2022-05-18 nodejs/reliability#281
Open
CI Reliability 2022-05-19 nodejs/reliability#282
Open
CI Reliability 2022-05-20 nodejs/reliability#283
Open
@climba03003 climba03003 mentioned this pull request May 20, 2022
undici leaking Symbol to global space in 18.2 (but not 18.1) #43157
Closed
This was referenced May 21, 2022
CI Reliability 2022-05-21 nodejs/reliability#284
Open
CI Reliability 2022-05-22 nodejs/reliability#285
Open
juanarbol pushed a commit that referenced this pull request May 31, 2022
@nodejs-github-bot @juanarbol
deps: update undici to 5.2.0
46d9308
PR-URL: #43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@nodejs-github-bot @danielleadams
deps: update undici to 5.2.0
f070bf0
PR-URL: #43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
deps: update undici to 5.2.0
7f1f217
PR-URL: #43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
deps: update undici to 5.2.0
b97075d
PR-URL: #43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
deps: update undici to 5.2.0
8e86984
PR-URL: nodejs/node#43059
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@kanongil

kanongil commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

I'm not a fan of this update polluting the javascript globals (Symbol(undici.globalDispatcher.1)), when it could just as easily have been exposed using a node: scoped module export.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@ronag ronag ronag approved these changes
@tniessen tniessen tniessen approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make it possible to use Fetch with proxies or other agents

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@nodejs-github-bot @panva @mcollina @targos @RafaelGSS @tniessen @Trott @kanongil @lpinca @ronag @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.