GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add WPT tests for dom/events by nissy-dev · Pull Request #43151 · nodejs/node

Conversation

@nissy-dev

@nissy-dev nissy-dev commented May 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Following the comment #40678 (comment), I added WPT tests for dom/events. The files except test/wpt/status/dom/events.json, test/wpt/test-events.js were generated by git-node wpt dom/events.

Currently, some tests are failed. Is it OK? or should I make some work for passing them? Many of them seem to fail due to lack of browser specific API like document is not undefined.

Refs: #40678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shisama reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nissy-dev
test: add WPT tests for dom/events
77804dc
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 19, 2022
@nissy-dev
nissy-dev marked this pull request as ready for review May 19, 2022 14:23
shisama
shisama approved these changes May 19, 2022
View reviewed changes

@shisama shisama left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding WPT test. I left some comments. But they are small things so it is ok not to fix them :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nissy-dev reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread test/wpt/status/dom/events.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/wpt/status/dom/events.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/wpt/status/dom/events.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nissy-dev

nissy-dev commented May 20, 2022

Copy link
Copy Markdown
Contributor Author

@shisama Thank you for reviews! Other member react your suggestion, so I will incorporate your correction.
shisama reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nissy-dev and others added 2 commits May 20, 2022 21:43
@nissy-dev @shisama
test: remove "unexpected" key in test/wpt/status/dom/events.json
7a7a589 
Co-authored-by: Masashi Hirano <[email protected]>
@nissy-dev @shisama
test: remove "unexpected" key in test/wpt/status/dom/events.json
363f835 
Co-authored-by: Masashi Hirano <[email protected]>
@nissy-dev

nissy-dev commented May 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@bnoordhuis
This PR is based on your comment. If you have a time, would you review it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes May 23, 2022
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shisama shisama added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 23, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 25, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 25, 2022
@nodejs-github-bot

nodejs-github-bot commented May 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44160/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 26, 2022
CI Reliability 2022-05-26 nodejs/reliability#289
Open
CI Reliability 2022-05-28 nodejs/reliability#291
Open
CI Reliability 2022-05-29 nodejs/reliability#292
Open
CI Reliability 2022-05-30 nodejs/reliability#293
Open
CI Reliability 2022-05-31 nodejs/reliability#294
Open
@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44333/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 4, 2022
CI Reliability 2022-06-04 nodejs/reliability#298
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44372/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shisama shisama added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 11, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44443/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jun 12, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 14, 2022
CI Reliability 2022-06-14 nodejs/reliability#300
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44639/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 18, 2022
CI Reliability 2022-06-18 nodejs/reliability#304
Open
34 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44671/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44709/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 19, 2022
CI Reliability 2022-06-19 nodejs/reliability#305
Open
30 tasks
@F3n67u

F3n67u commented Jun 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We could remove the following test, given they are already implemented in js in the latest wpt repo:

  1. test/parallel/test-eventtarget-whatwg-passive.js
  2. test/parallel/test-eventtarget-whatwg-signal.js
  3. test/parallel/test-eventtarget-whatwg-once.js

We could do the cleanup either in a separate pr or in this pr. I will be fine with both approaches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 20, 2022
CI Reliability 2022-06-20 nodejs/reliability#306
Open
36 tasks
@nissy-dev

nissy-dev commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

@F3n67u
Thank you for your comment! I will do the cleanup either in a separate pr because of flaky test in CI.
F3n67u reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u F3n67u mentioned this pull request Jun 21, 2022
events: add CustomEvent #43514
Merged
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8dce6ad into nodejs:main Jun 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8dce6ad
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nissy-dev
nissy-dev deleted the wpt-dom-events branch June 23, 2022 12:48
targos pushed a commit that referenced this pull request Jul 12, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
eece34c 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged
@F3n67u F3n67u mentioned this pull request Jul 17, 2022
test: remove test-whatwg-events-add-event-listener-options-once.js #43877
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
7a5823f 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nissy-dev @targos
test: add WPT tests for dom/events
bf5adf3 
PR-URL: #43151
Refs: #40678
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nissy-dev @guangwong
test: add WPT tests for dom/events
15ed34c 
PR-URL: nodejs/node#43151
Refs: nodejs/node#40678
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
+1 more reviewer
@shisama shisama shisama approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nissy-dev @nodejs-github-bot @F3n67u @bnoordhuis @jasnell @shisama @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.