GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — trace_events: add example for docs by theanarkh · Pull Request #43253 · nodejs/node

Conversation

@theanarkh

@theanarkh theanarkh commented May 30, 2022

Copy link
Copy Markdown
Contributor

add example for docs.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@theanarkh
trace_events: add example
a9acdb6
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 30, 2022
@F3n67u F3n67u added the review wanted PRs that need review. label Jul 26, 2022
ErickWendel
ErickWendel approved these changes Aug 16, 2022
View reviewed changes
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46046/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 16, 2022
@RaisinTen

RaisinTen commented Aug 16, 2022

Copy link
Copy Markdown
Member

@theanarkh btw, we don't do Jenkins CI runs on doc-only PRs :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh

theanarkh commented Aug 16, 2022

Copy link
Copy Markdown
Contributor Author

Oh, thanks. Can it be merged directly?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Aug 16, 2022

Copy link
Copy Markdown
Member

yes!
theanarkh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh theanarkh added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 16, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43253
✔  Done loading data for nodejs/node/pull/43253
----------------------------------- PR info ------------------------------------
Title      trace_events: add example for docs (#43253)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:update_trace_events_doc -> nodejs:main
Labels     doc, author ready, review wanted
Commits    1
 - trace_events: add example
Committers 1
 - theanarkh <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/43253
Reviewed-By: Erick Wendel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43253
Reviewed-By: Erick Wendel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 May 2022 18:28:01 GMT
   ✔  Approvals: 1
   ✔  - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/43253#pullrequestreview-1074032223
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2869381073
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh

theanarkh commented Aug 16, 2022

Copy link
Copy Markdown
Contributor Author

@RaisinTen Hi, it fails because of the CI, do i need to make it green or add some labels to skip the failure ?
RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46047/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh theanarkh added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 16, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b04f81c into nodejs:main Aug 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

Landed in b04f81c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 20, 2022
CI Reliability 2022-08-20 nodejs/reliability#352
Open
CI Reliability 2022-08-21 nodejs/reliability#353
Open
CI Reliability 2022-08-22 nodejs/reliability#354
Open
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@theanarkh @ruyadorno
trace_events: add example
2cf3ce8 
PR-URL: #43253
Reviewed-By: Erick Wendel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
targos pushed a commit that referenced this pull request Sep 5, 2022
@theanarkh @targos
trace_events: add example
4752e6a 
PR-URL: #43253
Reviewed-By: Erick Wendel <[email protected]>
@juanarbol juanarbol mentioned this pull request Oct 11, 2022
V16.18.0 proposal #44886
Merged
juanarbol pushed a commit that referenced this pull request Oct 11, 2022
@theanarkh @juanarbol
trace_events: add example
cb6b57f 
PR-URL: #43253
Reviewed-By: Erick Wendel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@theanarkh @guangwong
trace_events: add example
5a6fbd0 
PR-URL: nodejs/node#43253
Reviewed-By: Erick Wendel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@theanarkh @guangwong
trace_events: add example
93cefcd 
PR-URL: nodejs/node#43253
Reviewed-By: Erick Wendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErickWendel ErickWendel ErickWendel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@theanarkh @nodejs-github-bot @RaisinTen @ErickWendel @F3n67u
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.