GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update undici to 5.4.0 by nodejs-github-bot · Pull Request #43262 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 31, 2022 •
edited by mcollina
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.4.0.

Notable Change: we dropped the limits on the forbidden headers in fetch() as a spec deviation for server-side implementations.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels May 31, 2022
@tniessen

tniessen commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@panva

panva commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

@nodejs/undici

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented May 31, 2022

Copy link
Copy Markdown
Member

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

Might be a good idea for someone to change all the update GitHub jobs to delete the existing branch before creating the pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot @Trott
deps: update undici to 5.4.0
38ecb99
@Trott
Trott force-pushed the actions/tools-update-undici branch from c33f2de to 38ecb99 Compare May 31, 2022 12:55
@Trott

Trott commented May 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I fixed the branch with the following commands:

git checkout actions/tools-update-undici
git reset --hard upstream/actions/tools-update-undici
git rebase -i upstream/master
git push --force-with-lease upstream actions/tools-update-undici
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

panva
panva approved these changes May 31, 2022
View reviewed changes
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels May 31, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes May 31, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
richardlau
richardlau approved these changes May 31, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44256/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tniessen
tniessen approved these changes May 31, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes May 31, 2022
View reviewed changes
@mcollina mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label May 31, 2022
@mcollina mcollina mentioned this pull request May 31, 2022
v18.3.0 proposal #43266
Merged
@mcollina mcollina added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 31, 2022
@github-actions

github-actions Bot commented May 31, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

bengl, panva, and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Jun 1, 2022
CI Reliability 2022-06-01 nodejs/reliability#295
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44276/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44293/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44302/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44304/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Jun 1, 2022
@mcollina mcollina added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 921ef9b into master Jun 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator Author

Landed in 921ef9b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
aduh95 deleted the actions/tools-update-undici branch June 1, 2022 21:52
bengl pushed a commit that referenced this pull request Jun 1, 2022
@nodejs-github-bot @bengl
deps: update undici to 5.4.0
dc3b91f
PR-URL: #43262
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
bengl added a commit that referenced this pull request Jun 1, 2022
@bengl
2022-06-01, Version 18.3.0 (Current)
49362ef
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
@github-actions github-actions Bot mentioned this pull request Jun 2, 2022
CI Reliability 2022-06-02 nodejs/reliability#296
Open
19 tasks
bengl added a commit that referenced this pull request Jun 2, 2022
@bengl
2022-06-01, Version 18.3.0 (Current)
55f56ef
Notable changes:

* deps: update undici to 5.4.0  (Node.js GitHub Bot) #43262
* (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* deps: upgrade npm to 8.11.0 (npm team) #43210
* deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067
* (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740
* (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601
* (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397
* (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112
* (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740)
  * This means 32-bit Windows binaries are back with this release.

PR-URL: #43266
This was referenced Jun 3, 2022
CI Reliability 2022-06-03 nodejs/reliability#297
Open
CI Reliability 2022-06-04 nodejs/reliability#298
Open
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@nodejs-github-bot @danielleadams
deps: update undici to 5.4.0
4db4d53
PR-URL: #43262
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams added a commit that referenced this pull request Jun 27, 2022
@danielleadams
2022-06-28, Version 16.15.2 'Gallium' (LTS)
39950b4
Notable changes:

* deps:
  * update undici to 5.4.0 (Node.js GitHub Bot) #43262
* doc:
  * add LiviaMedeiros to collaborators (LiviaMedeiros) #43039
  * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824
  * add RafaelGSS to collaborators (RafaelGSS) #42718
  * add @meixg to collaborators (Xuguang Mei) #42576
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
deps: update undici to 5.4.0
bc6a368
PR-URL: #43262
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
deps: update undici to 5.4.0
0ff0094
PR-URL: #43262
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
deps: update undici to 5.4.0
d216dd7
PR-URL: nodejs/node#43262
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nodejs-github-bot @tniessen @panva @Trott @mcollina @richardlau @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.