GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: fix TODO in `freeze_intrinsics` by aduh95 · Pull Request #43472 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Jun 18, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
lib: fix TODO in freeze_intrinsics
5f04e34
@aduh95
aduh95 requested a review from guybedford June 18, 2022 16:04
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 18, 2022
guybedford
guybedford approved these changes Jun 18, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 18, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44705/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 19, 2022
CI Reliability 2022-06-19 nodejs/reliability#305
Open
30 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44715/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jun 20, 2022
CI Reliability 2022-06-20 nodejs/reliability#306
Open
36 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44770/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 21, 2022
CI Reliability 2022-06-21 nodejs/reliability#307
Open
CI Reliability 2022-06-22 nodejs/reliability#308
Open
CI Reliability 2022-06-23 nodejs/reliability#309
Open
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 411fb21 into nodejs:main Jun 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in 411fb21
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the freeze-intrinsics-todo branch June 27, 2022 16:27
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
lib: fix TODO in freeze_intrinsics
deaf4bb 
PR-URL: #43472
Reviewed-By: Guy Bedford <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@aduh95 @targos
lib: fix TODO in freeze_intrinsics
5fdc145 
PR-URL: #43472
Reviewed-By: Guy Bedford <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
lib: fix TODO in freeze_intrinsics
a97d0ba 
PR-URL: #43472
Reviewed-By: Guy Bedford <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
lib: fix TODO in freeze_intrinsics
20e8ac5 
PR-URL: nodejs/node#43472
Reviewed-By: Guy Bedford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedford guybedford guybedford approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@aduh95 @nodejs-github-bot @guybedford
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.